Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error validation #33

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix: improve error validation #33

merged 1 commit into from
Dec 15, 2023

Conversation

codebytere
Copy link
Member

Follow-up to #26.

Previously, if a user input an invalid PR or a PR that didn't exist, they would be redirected to the homepage. They should instead see some kind of error message indicating what went wrong, which they now will.

Screenshot 2023-12-14 at 9 09 03 PM Screenshot 2023-12-14 at 9 08 55 PM

@codebytere codebytere requested review from a team as code owners December 14, 2023 20:11
src/routes/pr.js Outdated Show resolved Hide resolved
src/views/pr-lookup.handlebars Outdated Show resolved Hide resolved
src/routes/pr.js Outdated Show resolved Hide resolved
@codebytere codebytere merged commit 0f5d30a into main Dec 15, 2023
2 checks passed
@codebytere codebytere deleted the error-validation branch December 15, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants