Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pipeline bus v1 #16644

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove pipeline bus v1 #16644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions logstash-core/src/main/java/org/logstash/plugins/pipeline/PipelineBus.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,7 @@ public interface PipelineBus {
* @return a new pipeline bus
*/
static PipelineBus create() {
final String pipelineBusImplementation = System.getProperty("logstash.pipelinebus.implementation", "v2");
switch (pipelineBusImplementation) {
case "v1": return new PipelineBusV1();
case "v2": return new PipelineBusV2();
default:
LOGGER.warn("unknown pipeline-bus implementation: {}", pipelineBusImplementation);
return new PipelineBusV1();
}
return new PipelineBusV2();
}

/**
Expand Down
238 changes: 0 additions & 238 deletions logstash-core/src/main/java/org/logstash/plugins/pipeline/PipelineBusV1.java
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion logstash-core/src/test/java/org/logstash/plugins/pipeline/PipelineBusTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public class PipelineBusTest {

@Parameterized.Parameters(name = "{0}")
public static Collection<Class<? extends PipelineBus.Testable>> data() {
return Set.of(PipelineBusV1.Testable.class, PipelineBusV2.Testable.class);
return Set.of(PipelineBusV2.Testable.class);
}

@Parameterized.Parameter
Expand Down