Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pipeline bus v1 #16644

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

yaauie
Copy link
Member

@yaauie yaauie commented Nov 5, 2024

Release notes

  • removes deprecated v1 pipeline bus; the v2 implementation has been the default since its introduction in Logstash 8.15.0

What does this PR do?

Removes the v1 implementation of the pipeline bus, which was only accessible through a never-documented system property escape hatch.

The property is deprecated on the 8.x branch in #16643

Why is it important/What is the impact to the user?

It should have no user impact; the escape hatch was never documented, and is not expected to be used in the real world.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

Copy link

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Copy link
Member

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like v1 was contained to just that single implementation file. Assuming #16643 deprecation is communicated in 8.x this removal looks clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants