Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] fix: [Search:AppSearch:Engines page]Data from page disappears after clicking on Last updated date (#201768) #204031

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…licking on Last updated date (elastic#201768)

Closes: elastic#200545
Closes: [elastic#8911](elastic/search-team#8911)

## Description
When user clicks date button it should activate correct action, or open
the new page. In this case, all data disappears from the page which is
unexpected. Found while testing for accessibility, but applicable to all
users.

## What was changed?:

1. Since LogsStream still uses `euiStyled`, and we use it in multiple
places, we need to set up `EuiThemeProvider` and `CellActionsProvider`.

## Screen:

<img width="1226" alt="image"
src="https://github.com/user-attachments/assets/cab55d3b-b694-4228-a0a2-7cfa9e0ac16d">

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 359ac08)
@kibanamachine kibanamachine merged commit 5c3dd15 into elastic:8.x Dec 12, 2024
11 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Integration Tests #4 / capacity based claiming should claim tasks to full capacity

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2314 2335 +21

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +1.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
enterpriseSearch 52.6KB 52.8KB +193.0B

cc @alexwizp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants