fix: [Search:AppSearch:Engines page]Data from page disappears after clicking on Last updated date #201768
+42
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
added
release_note:skip
|
/ci |
|
/ci |
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
alexwizp
added
backport:prev-minor
|
@elastic/obs-ux-logs-team please review |
tonyghiani
reviewed
Dec 3, 2024
x-pack/plugins/observability_solution/logs_shared/public/components/log_stream/log_stream.tsx
Outdated
Show resolved
Hide resolved
|
/ci |
|
/ci |
sphilipse
approved these changes
Dec 11, 2024
|
@elastic/kibana-core please review |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
rudolf
approved these changes
Dec 12, 2024
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 12, 2024
…licking on Last updated date (elastic#201768) Closes: elastic#200545 Closes: [elastic#8911](elastic/search-team#8911) ## Description When user clicks date button it should activate correct action, or open the new page. In this case, all data disappears from the page which is unexpected. Found while testing for accessibility, but applicable to all users. ## What was changed?: 1. Since LogsStream still uses `euiStyled`, and we use it in multiple places, we need to set up `EuiThemeProvider` and `CellActionsProvider`. ## Screen: <img width="1226" alt="image" src="https://github.com/user-attachments/assets/cab55d3b-b694-4228-a0a2-7cfa9e0ac16d"> --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 359ac08)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 12, 2024
…fter clicking on Last updated date (#201768) (#204031) # Backport This will backport the following commits from `main` to `8.x`: - [fix: [Search:AppSearch:Engines page]Data from page disappears after clicking on Last updated date (#201768)](#201768) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-12T14:10:06Z","message":"fix: [Search:AppSearch:Engines page]Data from page disappears after clicking on Last updated date (#201768)\n\nCloses: #200545\r\nCloses: [#8911](https://github.com/elastic/search-team/issues/8911)\r\n\r\n## Description\r\nWhen user clicks date button it should activate correct action, or open\r\nthe new page. In this case, all data disappears from the page which is\r\nunexpected. Found while testing for accessibility, but applicable to all\r\nusers.\r\n\r\n## What was changed?:\r\n\r\n1. Since LogsStream still uses `euiStyled`, and we use it in multiple\r\nplaces, we need to set up `EuiThemeProvider` and `CellActionsProvider`.\r\n\r\n## Screen: \r\n\r\n<img width=\"1226\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/cab55d3b-b694-4228-a0a2-7cfa9e0ac16d\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"359ac089de749c792fb1910229e94d5155d67921","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:prev-minor","ci:project-deploy-observability"],"title":"fix: [Search:AppSearch:Engines page]Data from page disappears after clicking on Last updated date","number":201768,"url":"https://github.com/elastic/kibana/pull/201768","mergeCommit":{"message":"fix: [Search:AppSearch:Engines page]Data from page disappears after clicking on Last updated date (#201768)\n\nCloses: #200545\r\nCloses: [#8911](https://github.com/elastic/search-team/issues/8911)\r\n\r\n## Description\r\nWhen user clicks date button it should activate correct action, or open\r\nthe new page. In this case, all data disappears from the page which is\r\nunexpected. Found while testing for accessibility, but applicable to all\r\nusers.\r\n\r\n## What was changed?:\r\n\r\n1. Since LogsStream still uses `euiStyled`, and we use it in multiple\r\nplaces, we need to set up `EuiThemeProvider` and `CellActionsProvider`.\r\n\r\n## Screen: \r\n\r\n<img width=\"1226\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/cab55d3b-b694-4228-a0a2-7cfa9e0ac16d\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"359ac089de749c792fb1910229e94d5155d67921"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201768","number":201768,"mergeCommit":{"message":"fix: [Search:AppSearch:Engines page]Data from page disappears after clicking on Last updated date (#201768)\n\nCloses: #200545\r\nCloses: [#8911](https://github.com/elastic/search-team/issues/8911)\r\n\r\n## Description\r\nWhen user clicks date button it should activate correct action, or open\r\nthe new page. In this case, all data disappears from the page which is\r\nunexpected. Found while testing for accessibility, but applicable to all\r\nusers.\r\n\r\n## What was changed?:\r\n\r\n1. Since LogsStream still uses `euiStyled`, and we use it in multiple\r\nplaces, we need to set up `EuiThemeProvider` and `CellActionsProvider`.\r\n\r\n## Screen: \r\n\r\n<img width=\"1226\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/cab55d3b-b694-4228-a0a2-7cfa9e0ac16d\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"359ac089de749c792fb1910229e94d5155d67921"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #200545
Closes: #8911
Description
When user clicks date button it should activate correct action, or open the new page. In this case, all data disappears from the page which is unexpected. Found while testing for accessibility, but applicable to all users.
What was changed?:
euiStyled, and we use it in multiple places, we need to set upEuiThemeProviderandCellActionsProvider.Screen: