Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation (#203545) #203987

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[8.x] [Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation (#203545) #203987

merged 1 commit into from
Dec 12, 2024
+40 −20

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@miloszmarcinkowski
[Profiling] Preserve kuery filters when switching between Universal…
62a629a 
… Profiling pages in new solution navigation (elastic#203545)

Closes elastic#197401

### Summary

This PR adds ability to preserve `kuery` filters when switching between
pages in Universal Profiling using `solution navigation`. The missing
filters were considered regression in comparison to `classic
navigation`.

### Testing

Expected behavior with **classic navigation** for comparison:
![Screen Recording 2024-12-10 at 14 40
26](https://github.com/user-attachments/assets/db066c2e-3a47-4ac1-9860-f00364716c19)

Before with **solution navigation**:
![Screen Recording 2024-12-10 at 14 50
21](https://github.com/user-attachments/assets/23481d63-37ee-4983-b8ef-5b3e6da2f55d)

After with **solution navigation**:
![Screen Recording 2024-12-10 at 14 45
30](https://github.com/user-attachments/assets/216b6c8d-bfb4-4f32-b4f8-40cf17f5847d)

(cherry picked from commit 881cdc1)
@kibanamachine kibanamachine enabled auto-merge (squash) December 12, 2024 10:29
@kibanamachine kibanamachine mentioned this pull request Dec 12, 2024
Merged
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 12, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 62a629a
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-203987-62a629a38060

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
profiling 17.4KB 17.7KB +266.0B

History

cc @miloszmarcinkowski

@kibanamachine kibanamachine merged commit 3cd88c8 into elastic:8.x Dec 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@miloszmarcinkowski miloszmarcinkowski

Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @elasticmachine @miloszmarcinkowski