[Profiling] Preserve kuery filters when switching between Universal Profiling pages in new solution navigation
#203545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miloszmarcinkowski
added
release_note:fix
backport:prev-major
…ages using Solution navigation
miloszmarcinkowski
force-pushed
the
197401-universal-profiling-preserve-filters-when-switching-between-universal-profiling-views
branch
from
1da83bf to
b85fffa
Compare
x-pack/plugins/observability_solution/profiling/public/plugin.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/profiling/public/plugin.tsx
Outdated
Show resolved
Hide resolved
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
@jennypavlova Thank you for review 🙌 I updated code according to 2nd comment. |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
History
|
| let isSidebarEnabled = true; | ||
| coreStart.chrome | ||
| .getChromeStyle$() | ||
| .pipe(take(1)) |
There was a problem hiding this comment.
why do we need this take(1)?
There was a problem hiding this comment.
We need take(1) to read current value from the observable and complete it immediately (no need to unsubscribe).
take(1) and first() operators are legit ways of unsubscribing observable. This is rxjs equivalent of useObservable method from react-use library or firstValueFrom helper from rxjs (but this one converts to Promise)
| ]; | ||
| return sections; | ||
| let isSidebarEnabled = true; | ||
| coreStart.chrome |
There was a problem hiding this comment.
Should this subscription be inside the map? This is creating N subscriptions. isn't it?
There was a problem hiding this comment.
Rxjs map() operator is called once when observable reads data stream. This isn't iterating over anything. Nothing wrong for me here.
There was a problem hiding this comment.
ah, yeah. You're right. I hadn't paid attention that this was rxjs map.
crespocarlos
approved these changes
Dec 12, 2024
|
Starting backport for target branches: 8.15, 8.16, 8.17, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 12, 2024
… Profiling pages in new solution navigation (elastic#203545) Closes elastic#197401 ### Summary This PR adds ability to preserve `kuery` filters when switching between pages in Universal Profiling using `solution navigation`. The missing filters were considered regression in comparison to `classic navigation`. ### Testing Expected behavior with **classic navigation** for comparison:  Before with **solution navigation**:  After with **solution navigation**:  (cherry picked from commit 881cdc1)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 12, 2024
… Profiling pages in new solution navigation (elastic#203545) Closes elastic#197401 ### Summary This PR adds ability to preserve `kuery` filters when switching between pages in Universal Profiling using `solution navigation`. The missing filters were considered regression in comparison to `classic navigation`. ### Testing Expected behavior with **classic navigation** for comparison:  Before with **solution navigation**:  After with **solution navigation**:  (cherry picked from commit 881cdc1)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 12, 2024
… Profiling pages in new solution navigation (elastic#203545) Closes elastic#197401 ### Summary This PR adds ability to preserve `kuery` filters when switching between pages in Universal Profiling using `solution navigation`. The missing filters were considered regression in comparison to `classic navigation`. ### Testing Expected behavior with **classic navigation** for comparison:  Before with **solution navigation**:  After with **solution navigation**:  (cherry picked from commit 881cdc1)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 12, 2024
… Profiling pages in new solution navigation (elastic#203545) Closes elastic#197401 ### Summary This PR adds ability to preserve `kuery` filters when switching between pages in Universal Profiling using `solution navigation`. The missing filters were considered regression in comparison to `classic navigation`. ### Testing Expected behavior with **classic navigation** for comparison:  Before with **solution navigation**:  After with **solution navigation**:  (cherry picked from commit 881cdc1)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
… Profiling pages in new solution navigation (elastic#203545) Closes elastic#197401 ### Summary This PR adds ability to preserve `kuery` filters when switching between pages in Universal Profiling using `solution navigation`. The missing filters were considered regression in comparison to `classic navigation`. ### Testing Expected behavior with **classic navigation** for comparison:  Before with **solution navigation**:  After with **solution navigation**: 
kibanamachine
added a commit
that referenced
this pull request
Dec 12, 2024
…between Universal Profiling pages in new solution navigation (#203545) (#203985) # Backport This will backport the following commits from `main` to `8.16`: - [[Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation (#203545)](#203545) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Milosz Marcinkowski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-12T10:23:24Z","message":"[Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation (#203545)\n\nCloses #197401\r\n\r\n### Summary\r\n\r\nThis PR adds ability to preserve `kuery` filters when switching between\r\npages in Universal Profiling using `solution navigation`. The missing\r\nfilters were considered regression in comparison to `classic\r\nnavigation`.\r\n\r\n### Testing\r\n\r\nExpected behavior with **classic navigation** for comparison:\r\n\r\n\r\nBefore with **solution navigation**:\r\n\r\n\r\nAfter with **solution navigation**:\r\n","sha":"881cdc142b3014f964a7b69fc8b29b85211fcbfa","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability"],"title":"[Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation","number":203545,"url":"https://github.com/elastic/kibana/pull/203545","mergeCommit":{"message":"[Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation (#203545)\n\nCloses #197401\r\n\r\n### Summary\r\n\r\nThis PR adds ability to preserve `kuery` filters when switching between\r\npages in Universal Profiling using `solution navigation`. The missing\r\nfilters were considered regression in comparison to `classic\r\nnavigation`.\r\n\r\n### Testing\r\n\r\nExpected behavior with **classic navigation** for comparison:\r\n\r\n\r\nBefore with **solution navigation**:\r\n\r\n\r\nAfter with **solution navigation**:\r\n","sha":"881cdc142b3014f964a7b69fc8b29b85211fcbfa"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203545","number":203545,"mergeCommit":{"message":"[Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation (#203545)\n\nCloses #197401\r\n\r\n### Summary\r\n\r\nThis PR adds ability to preserve `kuery` filters when switching between\r\npages in Universal Profiling using `solution navigation`. The missing\r\nfilters were considered regression in comparison to `classic\r\nnavigation`.\r\n\r\n### Testing\r\n\r\nExpected behavior with **classic navigation** for comparison:\r\n\r\n\r\nBefore with **solution navigation**:\r\n\r\n\r\nAfter with **solution navigation**:\r\n","sha":"881cdc142b3014f964a7b69fc8b29b85211fcbfa"}}]}] BACKPORT--> Co-authored-by: Milosz Marcinkowski <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 12, 2024
…between Universal Profiling pages in new solution navigation (#203545) (#203986) # Backport This will backport the following commits from `main` to `8.17`: - [[Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation (#203545)](#203545) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Milosz Marcinkowski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-12T10:23:24Z","message":"[Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation (#203545)\n\nCloses #197401\r\n\r\n### Summary\r\n\r\nThis PR adds ability to preserve `kuery` filters when switching between\r\npages in Universal Profiling using `solution navigation`. The missing\r\nfilters were considered regression in comparison to `classic\r\nnavigation`.\r\n\r\n### Testing\r\n\r\nExpected behavior with **classic navigation** for comparison:\r\n\r\n\r\nBefore with **solution navigation**:\r\n\r\n\r\nAfter with **solution navigation**:\r\n","sha":"881cdc142b3014f964a7b69fc8b29b85211fcbfa","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability"],"title":"[Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation","number":203545,"url":"https://github.com/elastic/kibana/pull/203545","mergeCommit":{"message":"[Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation (#203545)\n\nCloses #197401\r\n\r\n### Summary\r\n\r\nThis PR adds ability to preserve `kuery` filters when switching between\r\npages in Universal Profiling using `solution navigation`. The missing\r\nfilters were considered regression in comparison to `classic\r\nnavigation`.\r\n\r\n### Testing\r\n\r\nExpected behavior with **classic navigation** for comparison:\r\n\r\n\r\nBefore with **solution navigation**:\r\n\r\n\r\nAfter with **solution navigation**:\r\n","sha":"881cdc142b3014f964a7b69fc8b29b85211fcbfa"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203545","number":203545,"mergeCommit":{"message":"[Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation (#203545)\n\nCloses #197401\r\n\r\n### Summary\r\n\r\nThis PR adds ability to preserve `kuery` filters when switching between\r\npages in Universal Profiling using `solution navigation`. The missing\r\nfilters were considered regression in comparison to `classic\r\nnavigation`.\r\n\r\n### Testing\r\n\r\nExpected behavior with **classic navigation** for comparison:\r\n\r\n\r\nBefore with **solution navigation**:\r\n\r\n\r\nAfter with **solution navigation**:\r\n","sha":"881cdc142b3014f964a7b69fc8b29b85211fcbfa"}}]}] BACKPORT--> Co-authored-by: Milosz Marcinkowski <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 12, 2024
…etween Universal Profiling pages in new solution navigation (#203545) (#203987) # Backport This will backport the following commits from `main` to `8.x`: - [[Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation (#203545)](#203545) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Milosz Marcinkowski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-12T10:23:24Z","message":"[Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation (#203545)\n\nCloses #197401\r\n\r\n### Summary\r\n\r\nThis PR adds ability to preserve `kuery` filters when switching between\r\npages in Universal Profiling using `solution navigation`. The missing\r\nfilters were considered regression in comparison to `classic\r\nnavigation`.\r\n\r\n### Testing\r\n\r\nExpected behavior with **classic navigation** for comparison:\r\n\r\n\r\nBefore with **solution navigation**:\r\n\r\n\r\nAfter with **solution navigation**:\r\n","sha":"881cdc142b3014f964a7b69fc8b29b85211fcbfa","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability"],"title":"[Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation","number":203545,"url":"https://github.com/elastic/kibana/pull/203545","mergeCommit":{"message":"[Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation (#203545)\n\nCloses #197401\r\n\r\n### Summary\r\n\r\nThis PR adds ability to preserve `kuery` filters when switching between\r\npages in Universal Profiling using `solution navigation`. The missing\r\nfilters were considered regression in comparison to `classic\r\nnavigation`.\r\n\r\n### Testing\r\n\r\nExpected behavior with **classic navigation** for comparison:\r\n\r\n\r\nBefore with **solution navigation**:\r\n\r\n\r\nAfter with **solution navigation**:\r\n","sha":"881cdc142b3014f964a7b69fc8b29b85211fcbfa"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203545","number":203545,"mergeCommit":{"message":"[Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation (#203545)\n\nCloses #197401\r\n\r\n### Summary\r\n\r\nThis PR adds ability to preserve `kuery` filters when switching between\r\npages in Universal Profiling using `solution navigation`. The missing\r\nfilters were considered regression in comparison to `classic\r\nnavigation`.\r\n\r\n### Testing\r\n\r\nExpected behavior with **classic navigation** for comparison:\r\n\r\n\r\nBefore with **solution navigation**:\r\n\r\n\r\nAfter with **solution navigation**:\r\n","sha":"881cdc142b3014f964a7b69fc8b29b85211fcbfa"}}]}] BACKPORT--> Co-authored-by: Milosz Marcinkowski <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 12, 2024
…between Universal Profiling pages in new solution navigation (#203545) (#203984) # Backport This will backport the following commits from `main` to `8.15`: - [[Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation (#203545)](#203545) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Milosz Marcinkowski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-12T10:23:24Z","message":"[Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation (#203545)\n\nCloses #197401\r\n\r\n### Summary\r\n\r\nThis PR adds ability to preserve `kuery` filters when switching between\r\npages in Universal Profiling using `solution navigation`. The missing\r\nfilters were considered regression in comparison to `classic\r\nnavigation`.\r\n\r\n### Testing\r\n\r\nExpected behavior with **classic navigation** for comparison:\r\n\r\n\r\nBefore with **solution navigation**:\r\n\r\n\r\nAfter with **solution navigation**:\r\n","sha":"881cdc142b3014f964a7b69fc8b29b85211fcbfa","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability"],"title":"[Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation","number":203545,"url":"https://github.com/elastic/kibana/pull/203545","mergeCommit":{"message":"[Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation (#203545)\n\nCloses #197401\r\n\r\n### Summary\r\n\r\nThis PR adds ability to preserve `kuery` filters when switching between\r\npages in Universal Profiling using `solution navigation`. The missing\r\nfilters were considered regression in comparison to `classic\r\nnavigation`.\r\n\r\n### Testing\r\n\r\nExpected behavior with **classic navigation** for comparison:\r\n\r\n\r\nBefore with **solution navigation**:\r\n\r\n\r\nAfter with **solution navigation**:\r\n","sha":"881cdc142b3014f964a7b69fc8b29b85211fcbfa"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203545","number":203545,"mergeCommit":{"message":"[Profiling] Preserve `kuery` filters when switching between Universal Profiling pages in new solution navigation (#203545)\n\nCloses #197401\r\n\r\n### Summary\r\n\r\nThis PR adds ability to preserve `kuery` filters when switching between\r\npages in Universal Profiling using `solution navigation`. The missing\r\nfilters were considered regression in comparison to `classic\r\nnavigation`.\r\n\r\n### Testing\r\n\r\nExpected behavior with **classic navigation** for comparison:\r\n\r\n\r\nBefore with **solution navigation**:\r\n\r\n\r\nAfter with **solution navigation**:\r\n","sha":"881cdc142b3014f964a7b69fc8b29b85211fcbfa"}}]}] BACKPORT--> Co-authored-by: Milosz Marcinkowski <[email protected]>
|
This PR didn't make it on time for the latest v8.17.0 BC. Updating the labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #197401
Summary
This PR adds ability to preserve
kueryfilters when switching between pages in Universal Profiling usingsolution navigation. The missing filters were considered regression in comparison toclassic navigation.Testing
Expected behavior with classic navigation for comparison:
Before with solution navigation:
After with solution navigation:
