Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiProvider] Hide unwanted toast until a fix can be done !! #203244

Merged
merged 4 commits into from
Dec 6, 2024
Merged

[EuiProvider] Hide unwanted toast until a fix can be done !! #203244

merged 4 commits into from
Dec 6, 2024

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Dec 6, 2024 •
edited by kibanamachine
Loading

Summary

Hiding this until it can be fixed via #201805 !!

image

@shahzad31 shahzad31 requested a review from a team as a code owner December 6, 2024 15:20
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 6, 2024
tsullivan
tsullivan requested changes Dec 6, 2024
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add // @ts-expect-error above line 185

packages/core/chrome/core-chrome-browser-internal/src/chrome_service.tsx
@@ -240,7 +240,8 @@ export class ChromeService {
}: StartDeps): Promise<InternalChromeStart> {
this.initVisibility(application);
this.handleEuiFullScreenChanges();
this.handleEuiDevProviderWarning(notifications);
// commented out until https://github.com/elastic/kibana/issues/201805 can be fixed
// this.handleEuiDevProviderWarning(notifications);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahzad31 it looks like this creates a TS warning that might cause a CI failure, since handleEuiDevProviderWarning is declared but not used.

It looks like the warning is disregarded if we need to add // @ts-expect-error above line 185

@tsullivan tsullivan mentioned this pull request Dec 6, 2024
Open
tsullivan
tsullivan approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 449.9KB 449.9KB -36.0B

History

@shahzad31 shahzad31 merged commit 3548582 into elastic:main Dec 6, 2024
8 checks passed
@shahzad31 shahzad31 deleted the hide-toast branch December 6, 2024 19:00
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12204545434

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 6, 2024
@shahzad31
[EuiProvider] Hide unwanted toast until a fix can be done !! (elastic…
30d80a3 
…#203244)

## Summary

Hiding this until it can be fixed via
elastic#201805 !!

<img width="1341" alt="image"
src="https://github.com/user-attachments/assets/64d86aca-9c0e-4e94-9449-5f6a1c6a3288">

(cherry picked from commit 3548582)
@kibanamachine kibanamachine mentioned this pull request Dec 6, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 6, 2024
@kibanamachine @shahzad31
[8.x] [EuiProvider] Hide unwanted toast until a fix can be done !! (#…
e843309 
…203244) (#203327)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[EuiProvider] Hide unwanted toast until a fix can be done !!
(#203244)](#203244)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-06T18:59:55Z","message":"[EuiProvider]
Hide unwanted toast until a fix can be done !! (#203244)\n\n##
Summary\n\nHiding this until it can be fixed
via\nhttps://github.com//issues/201805 !!\n\n<img
width=\"1341\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/64d86aca-9c0e-4e94-9449-5f6a1c6a3288\">","sha":"354858264f84b624a6a4a1fc7a9b2961b7ba6ec0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[EuiProvider]
Hide unwanted toast until a fix can be done
!!","number":203244,"url":"https://github.com/elastic/kibana/pull/203244","mergeCommit":{"message":"[EuiProvider]
Hide unwanted toast until a fix can be done !! (#203244)\n\n##
Summary\n\nHiding this until it can be fixed
via\nhttps://github.com//issues/201805 !!\n\n<img
width=\"1341\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/64d86aca-9c0e-4e94-9449-5f6a1c6a3288\">","sha":"354858264f84b624a6a4a1fc7a9b2961b7ba6ec0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203244","number":203244,"mergeCommit":{"message":"[EuiProvider]
Hide unwanted toast until a fix can be done !! (#203244)\n\n##
Summary\n\nHiding this until it can be fixed
via\nhttps://github.com//issues/201805 !!\n\n<img
width=\"1341\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/64d86aca-9c0e-4e94-9449-5f6a1c6a3288\">","sha":"354858264f84b624a6a4a1fc7a9b2961b7ba6ec0"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <[email protected]>
markov00 pushed a commit to markov00/kibana that referenced this pull request Dec 7, 2024
@shahzad31 @markov00
[EuiProvider] Hide unwanted toast until a fix can be done !! (elastic…
f264f41 
…#203244)

## Summary

Hiding this until it can be fixed via
elastic#201805 !!

<img width="1341" alt="image"
src="https://github.com/user-attachments/assets/64d86aca-9c0e-4e94-9449-5f6a1c6a3288">
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@shahzad31 @SoniaSanzV
[EuiProvider] Hide unwanted toast until a fix can be done !! (elastic…
5ca6a8e 
…#203244)

## Summary

Hiding this until it can be fixed via
elastic#201805 !!

<img width="1341" alt="image"
src="https://github.com/user-attachments/assets/64d86aca-9c0e-4e94-9449-5f6a1c6a3288">
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@shahzad31 @SoniaSanzV
[EuiProvider] Hide unwanted toast until a fix can be done !! (elastic…
70e3f4e 
…#203244)

## Summary

Hiding this until it can be fixed via
elastic#201805 !!

<img width="1341" alt="image"
src="https://github.com/user-attachments/assets/64d86aca-9c0e-4e94-9449-5f6a1c6a3288">
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
@shahzad31 @CAWilson94
[EuiProvider] Hide unwanted toast until a fix can be done !! (elastic…
5bf15ca 
…#203244)

## Summary

Hiding this until it can be fixed via
elastic#201805 !!

<img width="1341" alt="image"
src="https://github.com/user-attachments/assets/64d86aca-9c0e-4e94-9449-5f6a1c6a3288">
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Dec 10, 2024
@shahzad31 @Samiul-TheSoccerFan
[EuiProvider] Hide unwanted toast until a fix can be done !! (elastic…
56863de 
…#203244)

## Summary

Hiding this until it can be fixed via
elastic#201805 !!

<img width="1341" alt="image"
src="https://github.com/user-attachments/assets/64d86aca-9c0e-4e94-9449-5f6a1c6a3288">
mykolaharmash pushed a commit to mykolaharmash/kibana that referenced this pull request Dec 11, 2024
@shahzad31 @mykolaharmash
[EuiProvider] Hide unwanted toast until a fix can be done !! (elastic…
092f9aa 
…#203244)

## Summary

Hiding this until it can be fixed via
elastic#201805 !!

<img width="1341" alt="image"
src="https://github.com/user-attachments/assets/64d86aca-9c0e-4e94-9449-5f6a1c6a3288">
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@shahzad31 @CAWilson94
[EuiProvider] Hide unwanted toast until a fix can be done !! (elastic…
29f6a1f 
…#203244)

## Summary

Hiding this until it can be fixed via
elastic#201805 !!

<img width="1341" alt="image"
src="https://github.com/user-attachments/assets/64d86aca-9c0e-4e94-9449-5f6a1c6a3288">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan tsullivan approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shahzad31 @elasticmachine @kibanamachine @tsullivan