Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] Nested EuiProvider error #201805

Open
tsullivan opened this issue Nov 26, 2024 · 4 comments
Open

[Observability] Nested EuiProvider error #201805

tsullivan opened this issue Nov 26, 2024 · 4 comments
Assignees
Labels
EUI Visual Refresh EUI Team:Observability Team label for Observability Team (for things that are handled across all of observability)

Comments

@tsullivan
Copy link
Member

tsullivan commented Nov 26, 2024

When running Kibana from source, many Observability pages are showing the following error:
Image

Cause:
EuiProvider is being rendered twice which is causing an internal EUI error to go off. This catches the error and displays the error toast. The text of the toast message is misleading: it says EuiProvider is missing when in reality it is mistakenly rendered twice.

This toast message exists because of a negative impact of rendering EuiProvider more than once in the page. EuiProvider initializes the Emotion cache, so this error message is to prevent double-caching.

The problem was recently introduced from changes in both #199748 and #199993.

Update 2024-12-06: A PR is currently in-flight to comment out the error message: #203244. Once the root cause is addressed, then the error message should be un-commented. But since the message is misleading, we also should update the wording to or try to find a way to show a more accurate message.

@tsullivan tsullivan added Team:Observability Team label for Observability Team (for things that are handled across all of observability) EUI EUI Visual Refresh labels Nov 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Observability)

@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@maryam-saeidi
Copy link
Member

Any progress on this one?

I see some adjustments in this test, and I was wondering if we are close to having a fix to avoid such steps in the test.

@shahzad31
Copy link
Contributor

this toast is temporarily commented out via PR, should be reverted once we have fix #203244

shahzad31 added a commit that referenced this issue Dec 6, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 6, 2024
…#203244)

## Summary

Hiding this until it can be fixed via
elastic#201805 !!

<img width="1341" alt="image"
src="https://github.com/user-attachments/assets/64d86aca-9c0e-4e94-9449-5f6a1c6a3288">

(cherry picked from commit 3548582)
kibanamachine added a commit that referenced this issue Dec 6, 2024
…203244) (#203327)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[EuiProvider] Hide unwanted toast until a fix can be done !!
(#203244)](#203244)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-06T18:59:55Z","message":"[EuiProvider]
Hide unwanted toast until a fix can be done !! (#203244)\n\n##
Summary\n\nHiding this until it can be fixed
via\nhttps://github.com//issues/201805 !!\n\n<img
width=\"1341\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/64d86aca-9c0e-4e94-9449-5f6a1c6a3288\">","sha":"354858264f84b624a6a4a1fc7a9b2961b7ba6ec0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[EuiProvider]
Hide unwanted toast until a fix can be done
!!","number":203244,"url":"https://github.com/elastic/kibana/pull/203244","mergeCommit":{"message":"[EuiProvider]
Hide unwanted toast until a fix can be done !! (#203244)\n\n##
Summary\n\nHiding this until it can be fixed
via\nhttps://github.com//issues/201805 !!\n\n<img
width=\"1341\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/64d86aca-9c0e-4e94-9449-5f6a1c6a3288\">","sha":"354858264f84b624a6a4a1fc7a9b2961b7ba6ec0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203244","number":203244,"mergeCommit":{"message":"[EuiProvider]
Hide unwanted toast until a fix can be done !! (#203244)\n\n##
Summary\n\nHiding this until it can be fixed
via\nhttps://github.com//issues/201805 !!\n\n<img
width=\"1341\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/64d86aca-9c0e-4e94-9449-5f6a1c6a3288\">","sha":"354858264f84b624a6a4a1fc7a9b2961b7ba6ec0"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <[email protected]>
markov00 pushed a commit to markov00/kibana that referenced this issue Dec 7, 2024
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this issue Dec 9, 2024
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this issue Dec 9, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 9, 2024
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this issue Dec 10, 2024
mykolaharmash pushed a commit to mykolaharmash/kibana that referenced this issue Dec 11, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EUI Visual Refresh EUI Team:Observability Team label for Observability Team (for things that are handled across all of observability)
Projects
None yet
Development

No branches or pull requests

5 participants