-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kbn-expect - add .eql support for sets #200034
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c5bc792
kbn-expect - add .eql support for sets
pheyos da6e6fb
Fix tsconfig
pheyos 44c129d
Merge branch 'main' into fix_expect_for_sets
pheyos adf3b39
Fix typo in comment
pheyos 307c207
Merge branch 'main' into fix_expect_for_sets
pheyos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the "Elastic License | ||
* 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side | ||
* Public License v 1"; you may not use this file except in compliance with, at | ||
* your election, the "Elastic License 2.0", the "GNU Affero General Public | ||
* License v3.0 only", or the "Server Side Public License, v 1". | ||
*/ | ||
|
||
// importing this package's expect as `kbnExpect` to not conflict with Jest's expect | ||
import kbnExpect from './expect'; | ||
|
||
it('asserts that sets with same entries but different ordering are equal', async () => { | ||
const setA = new Set(['a', 'b', 'c']); | ||
const setB = new Set(['c', 'b', 'a']); | ||
|
||
expect(() => { | ||
kbnExpect(setA).to.eql(setB); | ||
}).not.toThrow(); | ||
expect(() => { | ||
kbnExpect(setB).to.eql(setA); | ||
}).not.toThrow(); | ||
}); | ||
|
||
it('asserts that sets with same size but different entries are not equal', async () => { | ||
const setA = new Set(['a', 'b', 'c']); | ||
const setB = new Set(['x', 'y', 'z']); | ||
|
||
expect(() => { | ||
kbnExpect(setA).to.eql(setB); | ||
}).toThrow(); | ||
expect(() => { | ||
kbnExpect(setB).to.eql(setA); | ||
}).toThrow(); | ||
}); | ||
|
||
it('asserts that sets with different size but overlapping items are not equal', async () => { | ||
const setA = new Set(['a', 'b', 'c']); | ||
const setB = new Set(['a', 'b']); | ||
|
||
expect(() => { | ||
kbnExpect(setA).to.eql(setB); | ||
}).toThrow(); | ||
expect(() => { | ||
kbnExpect(setB).to.eql(setA); | ||
}).toThrow(); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the "Elastic License | ||
* 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side | ||
* Public License v 1"; you may not use this file except in compliance with, at | ||
* your election, the "Elastic License 2.0", the "GNU Affero General Public | ||
* License v3.0 only", or the "Server Side Public License, v 1". | ||
*/ | ||
|
||
module.exports = { | ||
preset: '@kbn/test/jest_node', | ||
rootDir: '../..', | ||
roots: ['<rootDir>/packages/kbn-expect'], | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The format doesn't know how to handle sets properly, so it applies the code for generic objects, which prints a failure message like this:
The quickest way to get a proper output was treating the sets as arrays for formatting purposes, which prints out failure messages like this: