kbn-expect - add .eql support for sets #200034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheyos
commented
Nov 13, 2024
Comment on lines
+650
to
+653
| // format sets like arrays | ||
| if (value instanceof Set) { | ||
| value = Array.from(value) | ||
| } |
There was a problem hiding this comment.
The format doesn't know how to handle sets properly, so it applies the code for generic objects, which prints a failure message like this:
expected {} to sort of equal {}
The quickest way to get a proper output was treating the sets as arrays for formatting purposes, which prints out failure messages like this:
expected [ 'a', 'b', 'c' ] to sort of equal [ 'x', 'y', 'z' ]
pheyos
added
release_note:skip
dmlemeshko
reviewed
Nov 14, 2024
dmlemeshko
approved these changes
Nov 14, 2024
💚 Build Succeeded
Metrics [docs]
History
cc @pheyos |
wayneseymour
pushed a commit
to wayneseymour/kibana
that referenced
this pull request
Nov 18, 2024
## Summary This PR adds support for asserting test equality with kbn-expect. It also introduces some unit tests to kbn-expect in order to verify the changes are working.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
## Summary This PR adds support for asserting test equality with kbn-expect. It also introduces some unit tests to kbn-expect in order to verify the changes are working.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
## Summary This PR adds support for asserting test equality with kbn-expect. It also introduces some unit tests to kbn-expect in order to verify the changes are working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for asserting test equality with kbn-expect. It also introduces some unit tests to kbn-expect in order to verify the changes are working.