Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ownership] Assign test files to Core Team #199771

Merged
merged 41 commits into from
Nov 19, 2024
Merged
Changes from 29 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
14468f3
Code owners check - match files and directories
pheyos Oct 25, 2024
63e1fc5
Merge branch 'adjust_co_check_script' of github.com:pheyos/kibana; br…
wayneseymour Oct 25, 2024
ddc568f
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Oct 25, 2024
d0ee568
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Oct 25, 2024
53d066b
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Oct 28, 2024
c5f5d67
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Oct 28, 2024
78742b9
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Oct 28, 2024
d51bd91
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Oct 29, 2024
5a02d9a
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Oct 29, 2024
6589a55
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Oct 30, 2024
6b3ab06
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Oct 30, 2024
8300515
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Oct 30, 2024
b31614d
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Oct 31, 2024
09dc65a
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Oct 31, 2024
a7ce136
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Nov 4, 2024
6178279
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Nov 4, 2024
1733f88
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Nov 4, 2024
1a412cf
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Nov 5, 2024
03d6cb6
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Nov 5, 2024
fe15e10
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Nov 6, 2024
47dd44b
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Nov 7, 2024
5e2f710
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Nov 7, 2024
3f701e6
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Nov 8, 2024
b5c38cd
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Nov 8, 2024
df184f7
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Nov 8, 2024
6a78ae6
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Nov 11, 2024
d1be929
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Nov 12, 2024
72b76e8
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Nov 12, 2024
5c3e55a
[Ownership] Assign test files to Core Team
wayneseymour Nov 12, 2024
9d2bb7d
move to shared ux per cr
wayneseymour Nov 13, 2024
137e6c0
Move to data discovery
wayneseymour Nov 13, 2024
c967af1
Drop
wayneseymour Nov 13, 2024
06ebc66
Mv to sharedux
wayneseymour Nov 13, 2024
4615fb2
Mv to shared ex
wayneseymour Nov 13, 2024
4ef8cf2
Move another shared ux
wayneseymour Nov 13, 2024
0213f80
Apply suggestions from code review
wayneseymour Nov 13, 2024
7227d8a
drop duplicates
wayneseymour Nov 13, 2024
fe0f8d2
drop more duplication
wayneseymour Nov 13, 2024
2ce91e9
Group plugin functional entries together
wayneseymour Nov 13, 2024
fff00c0
Merge branch 'main' into assign-core
elasticmachine Nov 18, 2024
eea90d8
Merge branch 'main' of github.com:elastic/kibana into assign-core
wayneseymour Nov 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 70 additions & 3 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -1423,10 +1423,77 @@ x-pack/test/api_integration/deployment_agnostic/services/ @elastic/appex-qa
x-pack/test/**/deployment_agnostic/ @elastic/appex-qa #temporarily to monitor tests migration

# Core
/test/plugin_functional/plugins/rendering_plugin @elastic/kibana-core
/test/plugin_functional/plugins/session_notifications @elastic/kibana-core
/x-pack/test/functional/page_objects/navigational_search.ts @elastic/kibana-core
/x-pack/test/stack_functional_integration/apps/savedobjects_upgrade_testing @elastic/kibana-core
/x-pack/test/functional/page_objects/status_page.ts @elastic/kibana-core
/x-pack/test/functional/page_objects/share_saved_objects_to_space_page.ts @elastic/kibana-core
jloleysens marked this conversation as resolved.
Show resolved Hide resolved
/x-pack/test/functional/page_objects/banners_page.ts @elastic/kibana-core
/x-pack/test/common/lib/test_data_loader.ts @elastic/kibana-core
/x-pack/test/api_integration/services/usage_api.ts @elastic/kibana-core
/x-pack/test/api_integration/apis/kibana @elastic/kibana-core
/test/api_integration/fixtures/import.ndjson @elastic/kibana-core
/x-pack/test/plugin_api_integration @elastic/kibana-core # Assigned per https://github.com/elastic/kibana/pull/146704
/x-pack/test/localization/ @elastic/kibana-core # Assigned per https://github.com/elastic/kibana/pull/146704
/test/ui_capabilities/newsfeed_err @elastic/kibana-core # Assigned per https://github.com/elastic/kibana/pull/66562
/test/server_integration/services/types.d.ts @elastic/kibana-core # Assigned per https://github.com/elastic/kibana/pull/81140
/test/server_integration/http @elastic/kibana-core
/test/scripts/run_multiple_kibana_nodes.sh @elastic/kibana-core
/test/plugin_functional/test_suites/application_links @elastic/kibana-core
/test/interpreter_functional/test_suites/run_pipeline @elastic/kibana-core
jloleysens marked this conversation as resolved.
Show resolved Hide resolved
/test/functional/services/usage_collection.ts @elastic/kibana-core
/test/functional/services/saved_objects_finder.ts @elastic/kibana-core
jloleysens marked this conversation as resolved.
Show resolved Hide resolved
/test/api_integration/fixtures/import_managed* @elastic/kibana-core
wayneseymour marked this conversation as resolved.
Show resolved Hide resolved
/test/functional/services/apps_menu.ts @elastic/kibana-core
/x-pack/test/functional/apps/status_page @elastic/kibana-core
/x-pack/test/cloud_integration @elastic/kibana-core
/x-pack/test/cloud_integration/plugins/saml_provider @elastic/kibana-core
/x-pack/test/functional_embedded/plugins/iframe_embedded @elastic/kibana-core
/test/server_integration/plugins/status_plugin_* @elastic/kibana-core
wayneseymour marked this conversation as resolved.
Show resolved Hide resolved
/x-pack/test/functional_cors @elastic/kibana-core
/x-pack/test/stack_functional_integration/apps/telemetry @elastic/kibana-core
/test/plugin_functional/test_suites/telemetry @elastic/kibana-core
/test/plugin_functional/test_suites/usage_collection @elastic/kibana-core
/test/plugin_functional/test_suites/saved_objects* @elastic/kibana-core
/test/plugin_functional/test_suites/core* @elastic/kibana-core
/test/plugin_functional/plugins/telemetry @elastic/kibana-core
/test/plugin_functional/plugins/session_notifications @elastic/kibana-core
/test/plugin_functional/plugins/kbn_top_nav/ @elastic/kibana-core
/test/plugin_functional/plugins/elasticsearch_client_plugin @elastic/kibana-core
/test/plugin_functional/plugins/app_link_test @elastic/kibana-core
/x-pack/test/plugin_functional/plugins/global_search_test @elastic/kibana-core
jloleysens marked this conversation as resolved.
Show resolved Hide resolved
/test/plugin_functional/plugins/saved_object* @elastic/kibana-core
/test/plugin_functional/plugins/rendering_plugin @elastic/kibana-core
/test/interpreter_functional/plugins/kbn_tp_run_pipeline @elastic/kibana-core
jloleysens marked this conversation as resolved.
Show resolved Hide resolved
/x-pack/test/functional/fixtures/kbn_archiver/saved_objects_management @elastic/kibana-core
/x-pack/test/functional_embedded @elastic/kibana-core
/test/plugin_functional/plugins/core* @elastic/kibana-core
/test/node_roles_functional @elastic/kibana-core
/test/functional/page_objects/newsfeed_page.ts @elastic/kibana-core # assigned per https://github.com/elastic/kibana/pull/160210
/test/functional/page_objects/home_page.ts @elastic/kibana-core
/test/functional/fixtures/es_archiver/deprecations_service @elastic/kibana-core
/test/health_gateway/**/* @elastic/kibana-core
wayneseymour marked this conversation as resolved.
Show resolved Hide resolved
/test/api_integration/apis/saved_objects* @elastic/kibana-core
/test/functional/apps/home @elastic/kibana-core
jloleysens marked this conversation as resolved.
Show resolved Hide resolved
/test/health_gateway @elastic/kibana-core
/test/node_roles_functional @elastic/kibana-core
/test/plugin_functional/plugins/app_link_test @elastic/kibana-core
/test/plugin_functional/plugins/kbn_top_nav @elastic/kibana-core
/test/plugin_functional/plugins/elasticsearch_client_plugin @elastic/kibana-core
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Would you mind grouping these with the other plugin_functional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure, but what do you mean by grouping them Jean-Louis?

Copy link
Contributor

@jloleysens jloleysens Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just meant placing them below the other ones, nothing fancy :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, as in within the core team assignments, group these together right?

Copy link
Member Author

@wayneseymour wayneseymour Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I noticed some duplication; dropped: 7227d8a , fe0f8d2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grouped them together as asked: 2ce91e9

/test/functional/firefox/home.config.ts @elastic/kibana-core
/test/functional/apps/status_page/*.ts @elastic/kibana-core
/test/functional/apps/home @elastic/kibana-core
jloleysens marked this conversation as resolved.
Show resolved Hide resolved
/test/functional/apps/bundles @elastic/kibana-core # Assigned per https://github.com/elastic/kibana/pull/64367
/test/examples/hello_world @elastic/kibana-core
/test/examples/routing/index.ts @elastic/kibana-core # Assigned per https://github.com/elastic/kibana/pull/69581
/test/common/plugins/newsfeed @elastic/kibana-core
/test/common/configure_http2.ts @elastic/kibana-core
/test/api_integration/apis/ui_counters @elastic/kibana-core
/test/api_integration/apis/telemetry/**/*.[j|t]s @elastic/kibana-core
wayneseymour marked this conversation as resolved.
Show resolved Hide resolved
/test/api_integration/apis/status @elastic/kibana-core
/test/api_integration/apis/stats @elastic/kibana-core # Assigned per: https://github.com/elastic/kibana/pull/20577
/test/api_integration/apis/saved_objects* @elastic/kibana-core
/test/api_integration/apis/home/*.ts @elastic/kibana-core
jloleysens marked this conversation as resolved.
Show resolved Hide resolved
/test/api_integration/apis/core/*.ts @elastic/kibana-core
/test/accessibility/apps/home.ts @elastic/kibana-core
jloleysens marked this conversation as resolved.
Show resolved Hide resolved
/x-pack/test/functional/apps/saved_objects_management @elastic/kibana-core
/x-pack/test/usage_collection @elastic/kibana-core
/x-pack/test/licensing_plugin @elastic/kibana-core
Expand Down