Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ownership] Assign test files to Core Team #199771
[Ownership] Assign test files to Core Team #199771
Changes from 29 commits
14468f3
63e1fc5
ddc568f
d0ee568
53d066b
c5f5d67
78742b9
d51bd91
5a02d9a
6589a55
6b3ab06
8300515
b31614d
09dc65a
a7ce136
6178279
1733f88
1a412cf
03d6cb6
fe15e10
47dd44b
5e2f710
3f701e6
b5c38cd
df184f7
6a78ae6
d1be929
72b76e8
5c3e55a
9d2bb7d
137e6c0
c967af1
06ebc66
4615fb2
4ef8cf2
0213f80
7227d8a
fe0f8d2
2ce91e9
fff00c0
eea90d8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Would you mind grouping these with the other
plugin_functional
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure, but what do you mean by grouping them Jean-Louis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just meant placing them below the other ones, nothing fancy :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, as in within the core team assignments, group these together right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I noticed some duplication; dropped: 7227d8a , fe0f8d2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grouped them together as asked: 2ce91e9