[Ownership] Assign test files to Core Team #199771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anch 'main' of github.com:elastic/kibana
wayneseymour
added
the
release_note:skip
jloleysens
reviewed
Nov 13, 2024
There was a problem hiding this comment.
Thanks for working through these files @wayneseymour !
I left some corrections/nits/opinions that I'd like to get your thoughts on!
.github/CODEOWNERS
Outdated
Comment on lines
1478
to
1480
| /test/plugin_functional/plugins/app_link_test @elastic/kibana-core | ||
| /test/plugin_functional/plugins/kbn_top_nav @elastic/kibana-core | ||
| /test/plugin_functional/plugins/elasticsearch_client_plugin @elastic/kibana-core |
There was a problem hiding this comment.
nit: Would you mind grouping these with the other plugin_functional?
There was a problem hiding this comment.
For sure, but what do you mean by grouping them Jean-Louis?
There was a problem hiding this comment.
I just meant placing them below the other ones, nothing fancy :)
There was a problem hiding this comment.
Ah ok, as in within the core team assignments, group these together right?
There was a problem hiding this comment.
Grouped them together as asked: 2ce91e9
Co-authored-by: Jean-Louis Leysens <[email protected]>
jloleysens
approved these changes
Nov 13, 2024
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
|
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
## Summary Assign test files to Core Team Contributes to: elastic#192979 --------- Co-authored-by: Robert Oskamp <[email protected]> Co-authored-by: Jean-Louis Leysens <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary Assign test files to Core Team Contributes to: elastic#192979 --------- Co-authored-by: Robert Oskamp <[email protected]> Co-authored-by: Jean-Louis Leysens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Assign test files to Core Team
Contributes to: #192979