Fix dataset path

README.md

@@ -83,13 +83,19 @@ Testing profiles are:
 
 ## Build the images
 
-> TODO (#16): run `export DATASET_PATH=/tmp` and then override it after generating a dataset to bypass this issue.
-
 To build all the docker images:
 
 ```bash
 docker compose -f docker/docker-compose.yml --profile "*" build
 ```
+
+> **NOTE:** there will be a warning as follows, we will take care of that environment variable later on.
+
+```bash
+WARN[0000] The "DATASET_NAME" variable is not set. Defaulting to a blank string.
+WARN[0000] The "DATASET_NAME" variable is not set. Defaulting to a blank string.
+```
+
 ## Dataset generation
 
 It generates a dataset with 300 annotated pictures where many scene conditions are randomized such as lighting and object pose.
@@ -111,7 +117,7 @@ And once it finishes (note the scene does not evolve anymore) check the generate
 To train a model you need a NVidia Omniverse synthetic dataset built in the previous step. You first need to set up the following environment variable:
 
 ```bash
-export DATASET_PATH=$(pwd)/isaac_ws/datasets/YYYYMMDDHHMMSS_out_fruit_sdg
+export DATASET_NAME=YYYYMMDDHHMMSS_out_fruit_sdg
 ```
 
 Then you can run the training using the training profile:
@@ -126,7 +132,7 @@ After the training ends, a `model.pth` file will be available inside `model`. Ad
 docker compose -f docker/docker-compose.yml --profile training_test up
 ```
 
-This will evaluate every image in the `DATASET_PATH` and generate annotated images in the `model` folder.
+This will evaluate every image in the `DATASET_NAME` and generate annotated images in the `model` folder.
 
 ## Run
 

docker/docker-compose.yml

@@ -14,7 +14,7 @@ services:
                  "-o",
                  "./model/model.pth"]
     volumes:
-      - ${DATASET_PATH}:/root/training_ws/data
+      - ../isaac_ws/datasets/${DATASET_NAME}:/root/training_ws/data
       - ../model/:/root/training_ws/model
       - torch_cache:/root/.cache/torch
     deploy:
@@ -41,7 +41,7 @@ services:
                  "-o",
                  "./model"]
     volumes:
-      - ${DATASET_PATH}:/root/training_ws/data
+      - ../isaac_ws/datasets/${DATASET_NAME}:/root/training_ws/data
       - ../model/:/root/training_ws/model
       - torch_cache:/root/.cache/torch
     deploy:
@@ -158,7 +158,6 @@ services:
       - DISPLAY
       - QT_X11_NO_MITSHM=1
       - XAUTHORITY=/tmp/.docker.xauth
-      - LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/isaac-sim/exts/omni.isaac.ros2_bridge/humble/lib
       - ROS_DISTRO=humble
       - ROS_DOMAIN_ID=0
       - RMW_IMPLEMENTATION=rmw_fastrtps_cpp
@@ -194,7 +193,6 @@ services:
       - DISPLAY
       - QT_X11_NO_MITSHM=1
       - XAUTHORITY=/tmp/.docker.xauth
-      - LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/isaac-sim/exts/omni.isaac.ros2_bridge/humble/lib
       - ROS_DISTRO=humble
       - ROS_DOMAIN_ID=0
       - RMW_IMPLEMENTATION=rmw_fastrtps_cpp

isaac_ws/entrypoint.sh

@@ -16,6 +16,7 @@
 
 SIM_SCRIPT_PATH="/root/isaac_ws/simulation_ws/scripts/launch_sim.py"
 SDG_SCRIPT_PATH="/root/isaac_ws/simulation_ws/scripts/launch_sdg.py"
+LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/isaac-sim/exts/omni.isaac.ros2_bridge/humble/lib
 
 SCRIPT_PATH=$(case "${MODE}" in
     "SIM") echo "${SIM_SCRIPT_PATH}" ;;
@@ -25,4 +26,6 @@ esac)
 
 cd /isaac-sim
 
+export LD_LIBRARY_PATH=${LD_LIBRARY_PATH}
+
 ./python.sh ${SCRIPT_PATH}