Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dataset path #59

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Fix dataset path #59

merged 2 commits into from
Sep 23, 2024

Conversation

agalbachicar
Copy link
Member

🦟 Bug fix

Fixes #16

Summary

This PR introduces 2 changes:

  • Moves the LD_LIBRARY_PATH variable to the entrypoint.sh script when using NVidia Omniverse Isaac and avoids a potential warning or wrong setting.
  • Mutates the DATASET_PATH to DATASET_NAME which produces a warning (documented in the README) but not an error when not set.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Copy link
Collaborator

@ndelima-ekumen ndelima-ekumen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agalbachicar agalbachicar merged commit 180c53f into main Sep 23, 2024
1 check passed
@agalbachicar agalbachicar deleted the agalbachicar/16_fix_dataset_path branch September 23, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix docker compose error when DATASET_PATH is not set
2 participants