Add support for -XX:Compatibility=elasticsearch #18387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If -XX:Compatibility=elasticsearch is specified:
* recognize -XX:+UseG1GC and -XX:-UseG1GC
* include flags G1HeapRegionSize, G1ReservePercent,
InitiatingHeapOccupancyPercent and UseG1GC
in -XX:+PrintFlagsFinal output
If -XX:Compatibility= is specified more than once, or with a mode
other than "elasticsearch" (not case-sensitive), the JVM will
refuse to start.
G1HeapRegionSize is derived from MaxHeapSize.
Signed-off-by: Keith W. Campbell <[email protected]>
keithc-ca
force-pushed
the
compatibility
branch
from
ef2da41 to
f316723
Compare
|
Pushed a minor change to the computation of |
tajila
reviewed
Nov 6, 2023
| @@ -6903,6 +6929,7 @@ protectedInitializeJavaVM(J9PortLibrary* portLibrary, void * userData) | |||
| int filter = -1; | |||
| #endif | |||
| J9JavaVM** BFUjavaVM; | |||
| IDATA xxUseG1GC = 0; /* +1 if -XX:+UseG1GC used; -1 if -XX:-UseG1GC used */ | |||
There was a problem hiding this comment.
Nevermind, I see we need third state for "command line" vs "ergonomic"
tajila
approved these changes
Nov 6, 2023
|
jenkins test sanity alinux64 jdk17 |
|
Pls open a docs issue. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
-XX:Compatibility=elasticsearchis specified:-XX:+UseG1GCand-XX:-UseG1GCG1HeapRegionSize,G1ReservePercent,InitiatingHeapOccupancyPercentandUseG1GCin-XX:+PrintFlagsFinaloutput (G1HeapRegionSizeis derived fromMaxHeapSize)If
-XX:Compatibility=is specified more than once, or with a mode other than"elasticsearch"(not case-sensitive), the JVM will refuse to start.Issue: #18265.