Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new -XX:Compatibility=elasticsearch option #1213

Closed
keithc-ca opened this issue Nov 14, 2023 · 3 comments · Fixed by #1254
Closed

Document new -XX:Compatibility=elasticsearch option #1213

keithc-ca opened this issue Nov 14, 2023 · 3 comments · Fixed by #1254
Assignees

Comments

@keithc-ca
Copy link
Contributor

keithc-ca commented Nov 14, 2023

Issue or pull request number:
eclipse-openj9/openj9#18265
eclipse-openj9/openj9#18387

Overview:
A new option, -XX:Compatibility=elasticsearch was added to allow using OpenJ9 with ElasticSearch.

Release target:
Eclipse OpenJ9 0.43.0

Applies to the following JDK versions:
All JDK versions (although ElasticSearch required Java 17+).

Applies to the following platforms:
All platforms

For new command line options:

  • Option name and syntax: -XX:Compatibility=elasticsearch
  • Purpose: Allow using OpenJ9 with ElasticSearch.
@Sreekala-Gopakumar
Copy link
Contributor

@keithc-ca - Is the following content correct? Could you please check and let me know the changes that are required. Thanks!

-XX:Compatibility

This option enables the compatibility mode that the OpenJDK can run in to support applications that require specific capabilities. For example, support for applications that rely on vendor-specific command line arguments or to make available unspecified APIs.

Syntax

    -XX:Compatibility=<mode>

Where, <mode> is the application for which the compatibility mode is provided. The <mode> is case-insensitive.

In release 0.43.0, the compatibility mode is provided for the Elasticsearch application only.

    -XX:Compatibility=Elasticsearch

If the -XX:Compatibility option is specified more than once, or with a mode other than "Elasticsearch" (not case-sensitive), the VM fails to start.

Although this option is available in all OpenJDK versions, but the Elasticsearch application requires OpenJDK version 17 or later.

Explanation

The Elasticsearch application was facing incompatibility issues when running on OpenJ9 and required many workarounds. With the Elasticsearch compatibility mode, OpenJ9 accepts and supports HotSpot-specific options or APIs that enhance compatibility to run the Elasticsearch application.

@keithc-ca
Copy link
Contributor Author

That looks good. The only suggestion I have is to replace "enables the compatibility mode" with "enables a compatibility mode" in the first sentence. The option structure allows for other modes although at most one can be specified.

@pshipton
Copy link
Member

We should use "OpenJ9" rather than "OpenJDK" in "that the OpenJDK can run in".
i.e. "that OpenJ9 can run in".

The following shouldn't use both "Although" and "but", one of them should be removed.
"Although this option is available in all OpenJDK versions, but the Elasticsearch application requires OpenJDK version 17 or later."

Sreekala-Gopakumar added a commit to Sreekala-Gopakumar/openj9-docs that referenced this issue Jan 19, 2024
eclipse-openj9#1213

Added new topic for the new option, -XX:Compatibility=elasticsearch. Updated the What's new topic and mkdocs.yml file.

Closes eclipse-openj9#1213
Signed-off-by: Sreekala Gopakumar <[email protected]>
Sreekala-Gopakumar added a commit to Sreekala-Gopakumar/openj9-docs that referenced this issue Jan 19, 2024
eclipse-openj9#1213

Added new topic for the new option, -XX:Compatibility=elasticsearch. Updated the What's new topic and mkdocs.yml file.

Closes eclipse-openj9#1213
Signed-off-by: Sreekala Gopakumar <[email protected]>
@Sreekala-Gopakumar Sreekala-Gopakumar self-assigned this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants