Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace NULL with 0 in call to generateSrc1Instruction #18244

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

dylanjtuttle
Copy link
Contributor

Fix AIX warning concerning an implicit conversion of NULL to int32_t. The null was being passed into generateSrc1Instruction, which was expecting an immediate of type int32_t. Other calls to this function in this same file pass a 0 to this parameter, so it seems sensible to do the same here for consistency.

This PR contributes to (but does not close) #14859

Fix AIX warning concerning an implicit conversion of NULL to int32_t
by replacing the NULL with a 0

Signed-off-by: Dylan Tuttle <[email protected]>
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@hzongaro
Copy link
Member

hzongaro commented Nov 1, 2023

Jenkins test sanity plinux,aix jdk8,jdk11,jdk17

@hzongaro
Copy link
Member

hzongaro commented Nov 2, 2023

Power Linux test failures were known CRIU problems. Merging.

@hzongaro hzongaro merged commit 42ff412 into eclipse-openj9:master Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants