Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove binding of NULL to non-pointer variable #7142

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

dylanjtuttle
Copy link
Contributor

Fix plinux warning concerning a conversion from NULL to intptr_t by removing the initial assignment of variable address to NULL. Since address is bound to a value immediately afterwards in both control flow paths through the if-else block which directly follows the variable definition, it's safe to not give it an initial value here.

The other instance of this warning will be fixed in openj9 #18244

This PR contributes to (but does not close) openj9 #14859

Copy link
Contributor

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@hzongaro
Copy link
Contributor

hzongaro commented Nov 9, 2023

Jenkins build plinux,aix

Fix plinux warning concerning a conversion from NULL to intptr_t
by removing the initial assignment of variable 'address' to NULL

Signed-off-by: Dylan Tuttle <[email protected]>
@hzongaro
Copy link
Contributor

hzongaro commented Nov 9, 2023

Jenkins build plinux,aix

@hzongaro
Copy link
Contributor

hzongaro commented Nov 9, 2023

Builds were successful and reviews signified approval. Merging.

@hzongaro hzongaro merged commit 811ded6 into eclipse-omr:master Nov 9, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants