Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable write permission before writing into CodeCache segment #18233

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions runtime/vm/segment.c
Original file line number Diff line number Diff line change
Expand Up @@ -409,8 +409,10 @@ static J9MemorySegment * allocateVirtualMemorySegmentInListInternal(J9JavaVM *ja
/* For CodeCache segments the JIT will later write a TR::CodeCache structure pointer at the begining of the segment.
* Until then, make sure that a potential reader sees a NULL pointer.
*/
omrthread_jit_write_protect_disable();
*((UDATA**)allocatedBase) = NULL;
issueWriteBarrier();
omrthread_jit_write_protect_enable();
}
segment->baseAddress = allocatedBase;
segment->heapBase = allocatedBase;
Expand Down