Enable write permission before writing into CodeCache segment #18233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`allocateVirtualMemorySegmentInListInternal` has been changed to write NULL into the code cache segment in eclipse-openj9#18212. The change does not include `omrthread_jit_write_protect_disable` and `omrthread_jit_write_protect_enable` calls before and after writing to the memory, which results in the crash on Apple Silicon Mac. This commit inserts `omrthread_jit_write_protect_disable` and `omrthread_jit_write_protect_enable` appropriately. Signed-off-by: Akira Saitoh <[email protected]>
Akira1Saitoh
force-pushed
the
AMacVirtualMemoryPermission
branch
from
4e0845f to
6983726
Compare
|
Jenkins test sanity alinux64,amac jdk17 |
This was referenced Oct 5, 2023
knn-k
approved these changes
Oct 5, 2023
|
FYI @mpirvu |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allocateVirtualMemorySegmentInListInternalhas been changed to write NULL into the code cache segment in #18212. The change does not includeomrthread_jit_write_protect_disableandomrthread_jit_write_protect_enablecalls before and after writing to the memory, which results in the crash on Apple Silicon Mac.This commit inserts
omrthread_jit_write_protect_disableandomrthread_jit_write_protect_enableappropriately.