Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio}[system/system] IGV v2.19.1 w/ Java 17 #22043

Merged

Conversation

pavelToman
Copy link
Collaborator

@pavelToman pavelToman commented Dec 17, 2024

(created using eb --new-pr)
resolves vscentrum/vsc-software-stack#474

Copy link

Updated software IGV-2.19.1-Java-17.eb

Diff against IGV-2.17.4-Java-17.eb

easybuild/easyconfigs/i/IGV/IGV-2.17.4-Java-17.eb

diff --git a/easybuild/easyconfigs/i/IGV/IGV-2.17.4-Java-17.eb b/easybuild/easyconfigs/i/IGV/IGV-2.19.1-Java-17.eb
index 35e427d0ad..9a2bc1d739 100644
--- a/easybuild/easyconfigs/i/IGV/IGV-2.17.4-Java-17.eb
+++ b/easybuild/easyconfigs/i/IGV/IGV-2.19.1-Java-17.eb
@@ -8,7 +8,7 @@
 easyblock = 'Tarball'
 
 name = 'IGV'
-version = '2.17.4'
+version = '2.19.1'
 versionsuffix = '-Java-%(javaver)s'
 
 homepage = 'https://www.broadinstitute.org/software/igv/'
@@ -20,7 +20,7 @@ toolchain = SYSTEM
 
 source_urls = ['http://data.broadinstitute.org/igv/projects/downloads/%(version_major)s.%(version_minor)s']
 sources = ['%(name)s_%(version)s.zip']
-checksums = ['6a36ae64fa3b74182db654a93f6254256305a8afa6b878f381b5d04fc1e8eaa5']
+checksums = ['e7d7803cab4e12e84f5359a3d73915a45acc6d676151ca18e91fb2d39432b568']
 
 dependencies = [('Java', '17', '', SYSTEM)]
 
Diff against IGV-2.16.0-Java-11.eb

easybuild/easyconfigs/i/IGV/IGV-2.16.0-Java-11.eb

diff --git a/easybuild/easyconfigs/i/IGV/IGV-2.16.0-Java-11.eb b/easybuild/easyconfigs/i/IGV/IGV-2.19.1-Java-17.eb
old mode 100755
new mode 100644
index d30a9dbd0f..9a2bc1d739
--- a/easybuild/easyconfigs/i/IGV/IGV-2.16.0-Java-11.eb
+++ b/easybuild/easyconfigs/i/IGV/IGV-2.19.1-Java-17.eb
@@ -8,7 +8,7 @@
 easyblock = 'Tarball'
 
 name = 'IGV'
-version = '2.16.0'
+version = '2.19.1'
 versionsuffix = '-Java-%(javaver)s'
 
 homepage = 'https://www.broadinstitute.org/software/igv/'
@@ -20,9 +20,9 @@ toolchain = SYSTEM
 
 source_urls = ['http://data.broadinstitute.org/igv/projects/downloads/%(version_major)s.%(version_minor)s']
 sources = ['%(name)s_%(version)s.zip']
-checksums = ['7fe76a793b1aa9ac90a1733acfe4ea01fd8e7e42729e9daee84e79e1f43b2a26']
+checksums = ['e7d7803cab4e12e84f5359a3d73915a45acc6d676151ca18e91fb2d39432b568']
 
-dependencies = [('Java', '11', '', SYSTEM)]
+dependencies = [('Java', '17', '', SYSTEM)]
 
 sanity_check_paths = {
     'files': ['%(namelower)s.sh', 'lib/%(namelower)s.jar'],
Diff against IGV-2.12.3-Java-11.eb

easybuild/easyconfigs/i/IGV/IGV-2.12.3-Java-11.eb

diff --git a/easybuild/easyconfigs/i/IGV/IGV-2.12.3-Java-11.eb b/easybuild/easyconfigs/i/IGV/IGV-2.19.1-Java-17.eb
index 7e992b8bba..9a2bc1d739 100644
--- a/easybuild/easyconfigs/i/IGV/IGV-2.12.3-Java-11.eb
+++ b/easybuild/easyconfigs/i/IGV/IGV-2.19.1-Java-17.eb
@@ -8,7 +8,7 @@
 easyblock = 'Tarball'
 
 name = 'IGV'
-version = '2.12.3'
+version = '2.19.1'
 versionsuffix = '-Java-%(javaver)s'
 
 homepage = 'https://www.broadinstitute.org/software/igv/'
@@ -20,9 +20,9 @@ toolchain = SYSTEM
 
 source_urls = ['http://data.broadinstitute.org/igv/projects/downloads/%(version_major)s.%(version_minor)s']
 sources = ['%(name)s_%(version)s.zip']
-checksums = ['c87a109deb35994e1b28dee80b5acfd623ec3257f031fcd9cfce008cd32a4cf2']
+checksums = ['e7d7803cab4e12e84f5359a3d73915a45acc6d676151ca18e91fb2d39432b568']
 
-dependencies = [('Java', '11', '', SYSTEM)]
+dependencies = [('Java', '17', '', SYSTEM)]
 
 sanity_check_paths = {
     'files': ['%(namelower)s.sh', 'lib/%(namelower)s.jar'],

@pavelToman
Copy link
Collaborator Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@pavelToman: Request for testing this PR well received on login1

PR test command 'EB_PR=22043 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_22043 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14879

Test results coming soon (I hope)...

- notification for comment with ID 2548593217 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/b25129da541bb5666b3fc3772a06e29d for a full test report.

@pavelToman
Copy link
Collaborator Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@pavelToman: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22043 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22043 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5456

Test results coming soon (I hope)...

- notification for comment with ID 2548619714 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.19
See https://gist.github.com/boegelbot/56529131ab874ce0654e04ac982a23af for a full test report.

@boegel
Copy link
Member

boegel commented Dec 17, 2024

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3105.skitty.os - Linux RHEL 9.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.9.18
See https://gist.github.com/boegel/614852a8bdf2e79bf3bc26c0ffd336ce for a full test report.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added this to the release after 4.9.4 milestone Dec 18, 2024
@Micket Micket merged commit 7f769c1 into easybuilders:develop Dec 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trim_Galore, IGV (, deeptools)
4 participants