This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
[WIP] internationalization #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
reviewed
May 20, 2021
| @@ -22,19 +22,19 @@ | |||
| <div class="panel-section panel-section-formElements"> | |||
| <div class="panel-formElements-item"> | |||
| <button id="stop" class="expander"> | |||
| Mettre en pause la surveillance des RDV | |||
| <!-- Mettre en pause la surveillance des RDV --> | |||
There was a problem hiding this comment.
Sorry, I'm not sure how to parse your question. 😕
I just kept the original texts as html comments, which are indeed supported by Firefox: the texts are hidden in the html rendering and added later by the js code. Is this what you asked?
9 tasks
|
@nanls thank you for your inspiration. I took the task over, as this PR seemed to stall a little bit and I needed the i18n for the german translations. This feature has been merged with #91. However, if you still want to contribute the English translations, all the translatable texts are now extracted to the https://github.com/dunglas/vaccin.click/blob/main/_locales/fr/messages.json |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started working on #22. It is my first time working on a browser add-on. Is this what you had in mind ?
Thanks in advance.