-
-
Notifications
You must be signed in to change notification settings - Fork 19
feat: doctolib.de germany compatibility #85
Conversation
const selectedDay = parseInt(parts[1]); | ||
const selectedYear = estimateYear(currentMonth, selectedMonth); | ||
const selectedTime = parts[3]; | ||
|
||
const date = new Date( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The date here is not really used for anything anymore, but this should fix it, there were little issues in the regex and the usage of parts
. Additionally, the part with the year could have been incorrect when being at the end of a year, like now. The estimateYear
function adds a year to the current one if the selected month is smaller than the current. This should work as long as we assume, that taking appointments in the past or in over a year should not be possible.
If I understand the code directly it was used before the 31st May 2020 to only search for available shots tomorrow. Should we remove the whole check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! This rule doesn't exist in France anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave it in for now, because it seems useful for #86 :)
… when making an appointment
…e now which one to use
069ffdc
to
23bb64e
Compare
This PR is ready now. I rebased and tested it again. Unfortunately, I didn't have enough time to work on it for the last 2 weeks. For the 2 open Todos, I'd like to work on them in separate PRs. What do you think? |
Thanks! |
I am currently working on the full compatibility of both sites https://doctolib.fr/ and https://doctolib.de/ at the same time.
However, it seems that booking flows significantly differentiate between both platforms, as the health systems may vary from country to country.
Features:
Bugfixes:
ToDo: