Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass testflight alpha group as an array to fastlane #2030

Merged
merged 6 commits into from
Sep 27, 2023
Merged

Pass testflight alpha group as an array to fastlane #2030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3e413bc
Pass testflight group as an array to fastlane
graeme Sep 21, 2023
1f7902d
Add one more param that might help
graeme Sep 21, 2023
3d14890
remove erroneous whitespace
graeme Sep 21, 2023
cb98319
Try submitting for beta review
graeme Sep 21, 2023
63fee3c
Remove submit_beta_review as it's default true
graeme Sep 21, 2023
bac2df3
Remove todos etc
graeme Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/alpha.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ jobs:
run: |
app_version="$(cut -d ' ' -f 3 < Configuration/Version.xcconfig)"
bundle exec fastlane increment_build_number_for_version version:$app_version app_identifier:"com.duckduckgo.mobile.ios.alpha"
bundle exec fastlane release_alpha groups:"${{ env.destination }}"
bundle exec fastlane release_alpha groups:["${{ env.destination }}"]
build_version="$(xcodebuild -configuration Alpha -showBuildSettings | grep CURRENT_PROJECT_VERSION | tr -d 'CURRENT_PROJECT_VERSION =')"
echo "dsyms_path=${{ github.workspace }}/DuckDuckGo-Alpha.app.dSYM.zip" >> $GITHUB_ENV
echo "app_version=${app_version}" >> $GITHUB_ENV
Expand Down
2 changes: 1 addition & 1 deletion fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ end

desc 'Increment build number based on version in App Store Connect'
lane :increment_build_number_for_version do |options|
app_identifier = "com.duckduckgo.mobile.ios"
app_identifier = "com.duckduckgo.mobile.ios"
if options[:app_identifier]
app_identifier = options[:app_identifier]
end
Expand Down