Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass testflight alpha group as an array to fastlane #2030

Merged
merged 6 commits into from
Sep 27, 2023

Conversation

graeme
Copy link
Contributor

@graeme graeme commented Sep 21, 2023

Task/Issue URL: https://app.asana.com/0/0/1205539796737793/f

Description:

We now have Alphas being distributed to TestFlight… but they seem to be ignoring the group. I’m trying passing this as an array as that’s what’s expected (was under the impression a string would also work, but examples online seem to show potentially otherwise).

Steps to test this PR:

  1. Just check TestFlight to see if the last build from this PR got added to the Latest Alpha Group

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@graeme graeme requested a review from samsymons September 21, 2023 18:25
@graeme
Copy link
Contributor Author

graeme commented Sep 26, 2023

@samsymons This is finally green. I think it would still be useful to merge this as it allows people to generate alphas and send them to specific groups (albeit after a TestFlight external group review has happened). So, while we wouldn’t use that straight away, it’s ready for when it’s needed.

The other option would be to remove any talk of groups altogether, but that’ll be another PR. I’ll let you decide if you think that would be better.

@samsymons samsymons self-assigned this Sep 26, 2023
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@graeme graeme merged commit 60ecf65 into develop Sep 27, 2023
8 checks passed
@graeme graeme deleted the graeme/add-alpha-testflight-group-as-array branch September 27, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants