Replace type checks with isinstance #427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should remove all Flake8 E721 errors
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #427 +/- ##
=======================================
Coverage 58.35% 58.35%
=======================================
Files 10 10
Lines 1340 1340
=======================================
Hits 782 782
Misses 558 558
☔ View full report in Codecov by Sentry. |
|
Dear @bencomp , It looks like @seanthegeek make some flake8 E721 issues. I suggest to rebase your PR on current main. Bests regards, |
|
I already did this. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should remove all Flake8 E721 errors that cause build failures.