Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action installs ElasticSearch before checking code style #428

Open
bencomp opened this issue Aug 22, 2023 · 0 comments
Open

GitHub Action installs ElasticSearch before checking code style #428

bencomp opened this issue Aug 22, 2023 · 0 comments

Comments

@bencomp
Copy link
Contributor

bencomp commented Aug 22, 2023

When I submitted #427 to fix the Flake8 errors that made an earlier build fail, I noticed that the current build workflow is set up to install ElasticSearch and other packages before checking the code style.

Perhaps "we" can save CI time by doing the light-weight code checking first, or even in parallel to other checks? And maybe caching dependencies can also save time, as well as using an ElasticSearch service container (though I have no experience with service containers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant