Implement interaction groups test mode and cofficient combine rule

[Ughuuu]

• Continues Add InteractionGroups::test_or, increase to 64 bits #170
• Fixes Feature: Add support for custom friction and bounce CombineRules #622

[Ughuuu]

Ok, added this mainly to stop using my fork and to try to use rapier default in godot-rapier. This way I hope to no longer need to maintain that and use this repo as it is. (if this gets merged)

[Ughuuu]

Fixed the doc test from CI.

[Vrixyz]

Should it be max(0.0) ?

[Vrixyz]

(outside of this PR's scope) @sebcrozet why does this function takes u8 rather than CoefficientCombineRule ?

[sebcrozet]

Should it be max(0.0) ?

I think there is some use-case for this in godot but that would be worth clarifying by @Ughuuu.

(outside of this PR's scope) @sebcrozet why does this function takes u8 rather than CoefficientCombineRule ?

I don’t think there is a particular reason for this.

[sebcrozet]

Thank you for this PR. Just a couple of clarifications needed and it’s good to go.
(Sorry for the delay for reviewing this.)

[sebcrozet]

This will create some hard to predict behavior if one of the interaction groups is set to AND while the other is set to OR. In that situation, whichever is self in this test will take precedence (and predicting which collider will be first here is not possible as it depends on some chains of events happening on the broad/narrow phase). I suggest setting an explicit precedence rule where InterecationTestMode::AND always has the priority:

Suggested change

	pub const fn test(self, rhs: Self) -> bool {
	match self.test_mode {
	InteractionTestMode::AND => self.test_and(rhs),
	InteractionTestMode::OR => self.test_or(rhs),
	}
	}
	pub const fn test(self, rhs: Self) -> bool {
	if self.test_mode == InteractionTestMode::And || rhs.test_mode == InteractionTestMode::And {
	self.test_and(rhs)
	} else {
	self.test_or(rhs)
	}

This precedence rule should be explained in the InteractionTestMode and InteractionGroups docs.

[sebcrozet]

The case is not idiomatic:

Suggested change

	#[default]
	AND,
	/// Use [`InteractionGroups::test_or`].
	OR,
	#[default]
	And,
	/// Use [`InteractionGroups::test_or`].
	Or,

[sebcrozet]

@Vrixyz Can you check why the non-idiomatic case wasn’t caught by CI please? I feel like this should have been a warning (that is denied in CI).

[Vrixyz]

That would be caught with this clippy lint:

https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms

with additional options in clippy.toml :

avoid-breaking-exported-api = false
upper-case-acronyms-aggressive = true

Unfortunately, This option also warns against SAPRegion and similar (+ TOIEntry, CCDSolver...) . We could suppress it for those specifics.

[sebcrozet]

Should it be max(0.0) ?

I think there is some use-case for this in godot but that would be worth clarifying by @Ughuuu.

(outside of this PR's scope) @sebcrozet why does this function takes u8 rather than CoefficientCombineRule ?

I don’t think there is a particular reason for this.