Fix one body joints limits not being flipped #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebcrozet
force-pushed
the
joint_flip_fix
branch
2 times, most recently
from
1ec47c4
to
dea5fa4
Compare
|
This is perfect, thank you @funmaker! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #549
I am not 100% convenient in the correctness of this change, but it does fix the issue I was experiencing in my program. Especially the changes to
JointGenericVelocityOneBodyExternalConstraintBuilder, since as far as I can tell this is used with multibodies, which I do not use. But I followed the same logic I did withJointOneBodyConstraintBuilder.I also removed some outdated TODO comments that are no longer relevant I think.