Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/test fix #84

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Bug/test fix #84

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b336475
cloudagent image to use:v0.8.2
Ellenn-A Aug 8, 2024
457d0f1
check-version not fail on the same version
Ellenn-A Aug 8, 2024
b4b7acc
remove fail on same version
Ellenn-A Aug 8, 2024
d598721
disabled renovate
Ellenn-A Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ jobs:
uses: digicatapult/check-version@v1
with:
token: ${{ secrets.GITHUB_TOKEN }}
fail_on_same_version: false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to use this flag as it essentially disables check version. Instead let's either just merge this and cancel the release workflow or if you want you can bump the version manually.

We have another ticket which will fix this problem so we can just bump versions with a label but that's not there yet


tests:
name: Run tests
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ jobs:
uses: digicatapult/check-version@v1
with:
token: ${{ secrets.GITHUB_TOKEN }}
fail_on_same_version: false

tests:
name: Run tests
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ services:

veritable:
container_name: ${COMPOSE_PROJECT_NAME}-veritable
image: digicatapult/veritable-cloudagent:${VERITABLE_AGENT_VER-latest}
image: digicatapult/veritable-cloudagent:v0.8.2
restart: on-failure
depends_on:
ipfs:
Expand Down
Loading