Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/test fix #84

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Bug/test fix #84

merged 4 commits into from
Aug 12, 2024

Conversation

Ellenn-A
Copy link
Contributor

@Ellenn-A Ellenn-A commented Aug 8, 2024

Pull Request

Checklist

  • Have you read Digital Catapult's Code of Conduct?
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

PR Type

Please delete options that are irrelevant.

  • Bug Fix
  • Feature
  • Documentation Update
  • Code style update (formatting, local variables)
  • Breaking Change (fix or feature that would cause existing functionality to change)

Linked tickets

High level description

Using veritable-cloudagent:v0.8.2 instead of latest to make the tests pass.

Detailed description

Using veritable-cloudagent:v0.8.2 instead of latest to make the tests pass. Will create a ticket in the backlog to have a look in more detail why tests fail when using latest image for veritable-cloudagent and fix it. Renovate has been disabled and this repository was labeled as non-production.

Describe alternatives you've considered

Trying to find out why the veritable-cloudagent:latest image fails tests, however this may take a long time.

Operational impact

N/A

Additional context

N/A

@Ellenn-A Ellenn-A requested a review from a team as a code owner August 8, 2024 10:15
Copy link

@n3op2 n3op2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few linting errors, wonder if they could be addressed along this PR, think deleting or commenting out should do.

@@ -89,6 +89,7 @@ jobs:
uses: digicatapult/check-version@v1
with:
token: ${{ secrets.GITHUB_TOKEN }}
fail_on_same_version: false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to use this flag as it essentially disables check version. Instead let's either just merge this and cancel the release workflow or if you want you can bump the version manually.

We have another ticket which will fix this problem so we can just bump versions with a label but that's not there yet

@Ellenn-A Ellenn-A merged commit 1855970 into main Aug 12, 2024
6 of 7 checks passed
@Ellenn-A Ellenn-A deleted the bug/test-fix branch August 12, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants