Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RovingFocus): add support for up/down arrows and home/end buttons #2206

Merged
merged 11 commits into from
Aug 12, 2024
Merged

feat(RovingFocus): add support for up/down arrows and home/end buttons #2206

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c744161
feat(RovingIndex): add support for up/down arrows and home/end buttons
Barsnes Aug 6, 2024
b97a808
Create bright-knives-remain.md
Barsnes Aug 6, 2024
2d700cd
add props for direction
Barsnes Aug 7, 2024
3ace283
better prevent default handling
Barsnes Aug 7, 2024
2a8d286
use switch statement
Barsnes Aug 7, 2024
7c9ca74
change to orientation
Barsnes Aug 7, 2024
97aef8a
update changeset
Barsnes Aug 7, 2024
ebbbc60
add aria-orientation
Barsnes Aug 7, 2024
438ae9d
refactor switch statement
Barsnes Aug 12, 2024
1267a48
rename to RovingFocus in changeset
Barsnes Aug 12, 2024
94ab418
remove aria-orientation
Barsnes Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/bright-knives-remain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@digdir/designsystemet-react": patch
---

RovingIndex: add support for up/down arrows and home/end buttons
mimarz marked this conversation as resolved.
Show resolved Hide resolved
16 changes: 14 additions & 2 deletions packages/react/src/utilities/RovingFocus/RovingFocusItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,24 @@ export const RovingFocusItem = forwardRef<HTMLElement, RovingFocusItemProps>(
const items = getOrderedItems();
let nextItem: RovingFocusElement | undefined;

if (e.key === 'ArrowRight') {
if (e.key === 'ArrowRight' || e.key === 'ArrowDown') {
nextItem = getNextFocusableValue(items, focusValue);
e.preventDefault();
}

if (e.key === 'ArrowLeft') {
if (e.key === 'ArrowLeft' || e.key === 'ArrowUp') {
Barsnes marked this conversation as resolved.
Show resolved Hide resolved
nextItem = getPrevFocusableValue(items, focusValue);
e.preventDefault();
}

if (e.key === 'Home') {
nextItem = items[0];
e.preventDefault();
}

if (e.key === 'End') {
nextItem = items[items.length - 1];
e.preventDefault();
}

nextItem?.element.focus();
Expand Down
Loading