-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RovingFocus): add support for up/down arrows and home/end buttons #2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 94ab418 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Preview deployments for this pull request: 📖 Storybook See all deployments at https://dev.designsystemet.no |
mimarz
requested changes
Aug 7, 2024
mimarz
requested changes
Aug 7, 2024
Barsnes
changed the title
feat(RovingIndex): add support for up/down arrows and home/end buttons
feat(RovingFocus): add support for up/down arrows and home/end buttons
Aug 12, 2024
mimarz
approved these changes
Aug 12, 2024
mimarz
pushed a commit
that referenced
this pull request
Aug 14, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `next` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `next`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @digdir/[email protected] ### Minor Changes - feat: Convert to W3C design token format ([#2240](#2240)) ### Patch Changes - refactor: single CSS file for theme ([#2204](#2204)) - fix: Export correct types for color ([`e6325afa14e349698daf1082ba8844e80f46c5c0`](e6325af)) ## @digdir/[email protected] ### Minor Changes - Breadcrumbs: ✨ new component ([#2226](#2226)) - Badge: ✨ New component ([#2220](#2220)) ### Patch Changes - Modal: add missing ModalRoot export ([#2228](#2228)) - RovingFocus: add `orientation` to support for different arrow directions, and add support home/end buttons ([#2206](#2206)) - Affects `ToggleGroup`, where up and down arrows can now be used - Affects `ToggleGroup`, where home and end can now be used - Affects `Tabs`, where home and end can now be used - Accordion: Fix `defaultOpen` flicker on first render ([#2214](#2214)) - Tabs: Make arrow keys work in any direction ([#2223](#2223)) - Fixes so spacing is the same in checkbox and radio groups ([#2234](#2234)) - Divider: hide from screen readers ([#2232](#2232)) - Modal: remove `FloatingFocusManager` ([#2224](#2224)) - NativeSelect: add focus in `readOnly` state ([#2212](#2212)) ## @digdir/[email protected] ### Patch Changes - Fixes so spacing is the same in checkbox and radio groups ([#2234](#2234)) - Button: `text-align: inherit` when not in full width ([#2216](#2216)) - Breadcrumbs: ✨ new component ([#2226](#2226)) - Badge: ✨ New component ([#2220](#2220)) ## @digdir/[email protected] ### Patch Changes - refactor: single CSS file for theme ([#2204](#2204)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.