Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Combobox): 🐛 Click to open/close should now close when open #2184

Merged
merged 8 commits into from
Jul 25, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
snapshot tag input
mimarz committed Jul 25, 2024
commit e7c0a2f4e16c41d604b6f56fe5534d8ea8d22b13
10 changes: 8 additions & 2 deletions .github/workflows/release-snapshot.yml
Original file line number Diff line number Diff line change
@@ -3,6 +3,10 @@ name: Release Snapshot

on:
workflow_dispatch:
inputs:
tag:
description: 'NPM tag'
default: ''

jobs:
snapshot:
@@ -11,6 +15,8 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/gh-setup
- id: variables
run: echo "tag=${{ github.event.inputs.tag != '' && github.event.inputs.tag || github.ref_name }}" >> $GITHUB_OUTPUT
- name: Creating .npmrc
run: |
cat << EOF > "$HOME/.npmrc"
@@ -20,9 +26,9 @@ jobs:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
- name: Create Snapshot Release
run: |
yarn run version-packages --snapshot "${{ github.ref_name }}"
yarn run version-packages --snapshot "${{ steps.variables.outputs.tag }}"
echo '---'
echo 'Detected Changes:'
git diff
echo '---'
yarn run publish --tag "${{ github.ref_name }}" --no-git-tag
yarn run publish --tag "${{ steps.variables.outputs.tag }}" --no-git-tag

Unchanged files with check annotations Beta

updateColor('brand1', queryBrand1, colors.brand1);
updateColor('brand2', queryBrand2, colors.brand2);
updateColor('brand3', queryBrand3, colors.brand3);
// eslint-disable-next-line react-hooks/exhaustive-deps

Check warning on line 89 in apps/theme/app/page.tsx

GitHub Actions / Builds, lints and tests code

React Compiler has skipped optimizing this component because one or more React ESLint rules were disabled. React Compiler only works when your components follow all the rules of React, disabling them may result in unexpected or incorrect behavior
}, [contrastMode]);
useEffect(() => {
if (typeof borderRadius === 'string') {
updateBoderRadius(borderRadius);
}
}, []);

Check warning on line 230 in apps/theme/app/page.tsx

GitHub Actions / Builds, lints and tests code

React Hook useEffect has missing dependencies: 'params' and 'updateBoderRadius'. Either include them or remove the dependency array
/**
* Get the color error for a color
const darkCSS = generateCSSVars('dark');
const contrastCSS = generateCSSVars('contrast');
setCss(lightCSS + darkCSS + contrastCSS);
// eslint-disable-next-line react-hooks/exhaustive-deps

Check warning on line 162 in apps/theme/components/TokenModal/TokenModal.tsx

GitHub Actions / Builds, lints and tests code

React Compiler has skipped optimizing this component because one or more React ESLint rules were disabled. React Compiler only works when your components follow all the rules of React, disabling them may result in unexpected or incorrect behavior
}, []);
return (