Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Combobox): 🐛 Click to open/close should now close when open #2184

Merged
merged 8 commits into from
Jul 25, 2024
Merged

fix(Combobox): 🐛 Click to open/close should now close when open #2184

merged 8 commits into from
Jul 25, 2024

Conversation

mimarz
Copy link
Collaborator

@mimarz mimarz commented Jul 24, 2024

fixes #2180

@mimarz mimarz requested a review from Barsnes as a code owner July 24, 2024 14:37
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: e19a964

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@digdir/designsystemet-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 24, 2024 •
edited
Loading

Preview deployments for this pull request:

📖 Storybook 25. Jul 2024 - 10:28 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@mimarz mimarz changed the title fix(Combobox): 🐛 Button for toggling open/close should now close when open fix(Combobox): 🐛 Click to open/close should now close when open Jul 25, 2024
@mimarz mimarz merged commit 8b2abdb into next Jul 25, 2024
5 checks passed
@mimarz mimarz deleted the fix/combobox-toggle-button branch July 25, 2024 08:38
@github-actions github-actions bot mentioned this pull request Jul 26, 2024
Merged
mimarz pushed a commit that referenced this pull request Jul 26, 2024
@github-actions
Version Packages (next) (#2186)
a7cf236 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to next, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`next` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `next`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @digdir/[email protected]

### Patch Changes

-
[`2d1da9a`](2d1da9a)
Thanks [@mimarz](https://github.com/mimarz)! - Testing snapshot release

All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit
guidelines.

# 0.1.0-alpha.6 (2024-06-11)

### Features

- 🎨 V1 Release candidate
([#1849](#1849))
([917ac1f](917ac1f))

## @digdir/[email protected]

### Patch Changes

-
[`2d1da9a`](2d1da9a)
Thanks [@mimarz](https://github.com/mimarz)! - Testing snapshot release

All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit
guidelines.

#
[0.11.0-alpha.2](https://github.com/digdir/designsystemet/compare/@digdir/[email protected]...@digdir/[email protected])
(2024-06-11)

### Features

- 🎨 V1 Release candidate
([#1849](#1849))
([917ac1f](917ac1f))

### Reverts

- Revert "Publish"
([8b3c1a1](8b3c1a1))

#
[0.10.0](https://github.com/digdir/designsystemet/compare/@digdir/[email protected]...@digdir/[email protected])
(2024-06-07)

### Bug Fixes

- **Heading:** ⚰️ Remove non-working `3xlarge`/`3xl` size
([#2074](#2074))
([dad4c8e](dad4c8e))

### Features

- **css:** use native selectors
([#2050](#2050))
([f1747b0](f1747b0))

#
[0.9.0](https://github.com/digdir/designsystemet/compare/@digdir/[email protected]...@digdir/[email protected])
(2024-05-24)

### Bug Fixes

- **Combobox:** remove wrong padding
([#2067](#2067))
([0a60499](0a60499))
- **RadioGroup:** bigger horizontal gap between inputs
([#2068](#2068))
([c9818ec](c9818ec))
- **Tabs:** active tab has wrong hover style
([#2061](#2061))
([104e16d](104e16d))

### Features

- **Alert:** add shorthand sizes
([#1995](#1995))
([868d214](868d214))
- **Box:** add shorthand sizes
([#2048](#2048))
([05901c0](05901c0))
- **Checkbox:** add shorthand sizes
([#2030](#2030))
([e2ca09d](e2ca09d))
- **Chips:** add shorthand sizes
([#2007](#2007))
([318d1ee](318d1ee))
- **Combobox:** add shorthand sizes
([#2029](#2029))
([f1ef9fe](f1ef9fe))
- **DropdownMenu:** add shorthand sizes
([#2021](#2021))
([cf17310](cf17310))
- **ErrorMessage:** add shorthand sizes
([#2019](#2019))
([c511c59](c511c59))
- **Heading:** add shorthand sizes
([#1997](#1997))
([265a3c7](265a3c7))
- **HelpText:** add shorthand sizes
([#2014](#2014))
([ad97311](ad97311))
- **Ingress:** add shorthand sizes
([#2020](#2020))
([62caef5](62caef5))
- **Label:** add shorthand sizes
([#1999](#1999))
([919c43c](919c43c))
- **NativeSelect:** add shorthand sizes
([#2033](#2033))
([1d494d1](1d494d1))
- **Pagination:** add shorthand sizes
([#2034](#2034))
([1c549b7](1c549b7))
- **Paragraph:** add shorthand sizes
([#1996](#1996))
([72a7824](72a7824))
- **Popover:** add shorthand sizes
([#2006](#2006))
([6637c52](6637c52))
- **Radio:** add shorthand sizes
([#2036](#2036))
([20278fa](20278fa))
- **Search:** add shorthand sizes
([#2028](#2028))
([d8fc81d](d8fc81d))
- **Switch:** add shorthand sizes
([#2027](#2027))
([bd5160b](bd5160b))
- **Table:** add shorthand sizes
([#2016](#2016))
([50cbb8e](50cbb8e))
- **Tabs:** add shorthand sizes
([#2012](#2012))
([806125d](806125d))
- **Tag:** add shorthand sizes
([#2017](#2017))
([405f55d](405f55d))
- **Textarea:** add shorthand sizes
([#2031](#2031))
([5932d5e](5932d5e))
- **Textfield:** add shorthand sizes
([#2018](#2018))
([9c52938](9c52938))

#
[0.8.0](https://github.com/digdir/designsystemet/compare/@digdir/[email protected]...@digdir/[email protected])
(2024-05-16)

### Features

- **Button:** add shorthand sizes
([#1986](#1986))
([38a5232](38a5232))

#
[0.7.0](https://github.com/digdir/designsystemet/compare/@digdir/[email protected]...@digdir/[email protected])
(2024-05-14)

### Bug Fixes

- **Combobox:** Improve performance
([#1771](#1771))
([18cdd17](18cdd17))
- **Modal:** fix close button position
([#1877](#1877))
([c866710](c866710))

### Features

- **Button:** 💄 Add top & bottom padding
([#1910](#1910))
([efd0582](efd0582))

## @digdir/[email protected]

### Patch Changes

-
[`2d1da9a`](2d1da9a)
Thanks [@mimarz](https://github.com/mimarz)! - Testing snapshot release

- [#2184](#2184)
[`8b2abdb`](8b2abdb)
Thanks [@mimarz](https://github.com/mimarz)! - fix(Combobox): 🐛
Button for toggling open/close should now close when open

- [#2185](#2185)
[`567329b`](567329b)
Thanks [@mimarz](https://github.com/mimarz)! - feat(Combobox):
:sparkles: Label now supports other elements

All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit
guidelines.

#
[1.0.0-rc.6](https://github.com/digdir/designsystemet/compare/@digdir/[email protected]...@digdir/[email protected])
(2024-06-11)

### Bug Fixes

- **Tab:** Use correct type on Tab button
([f3f5949](f3f5949))

### Features

- 🎨 V1 Release candidate
([#1849](#1849))
([917ac1f](917ac1f))

### Reverts

- Revert "Publish"
([8b3c1a1](8b3c1a1))

#
[0.63.0](https://github.com/digdir/designsystemet/compare/@digdir/[email protected]...@digdir/[email protected])
(2024-06-07)

### Bug Fixes

- **Combobox:** make value as string of integer work
([#2095](#2095))
([0a687f2](0a687f2)),
closes [#2081](#2081)
[#2106](#2106)
- **Heading:** ⚰️ Remove non-working `3xlarge`/`3xl` size
([#2074](#2074))
([dad4c8e](dad4c8e))

### Features

- **css:** use native selectors
([#2050](#2050))
([f1747b0](f1747b0))

#
[0.62.0](https://github.com/digdir/designsystemet/compare/@digdir/[email protected]...@digdir/[email protected])
(2024-05-24)

### Bug Fixes

- **Tabs:** `className` being overridden
([#2064](#2064))
([10fb504](10fb504))
- **Tabs:** active tab has wrong hover style
([#2061](#2061))
([104e16d](104e16d))
- **Textfield:** character counter inital value
([#2056](#2056))
([7b5df7f](7b5df7f))
- **Tooltip:** rendered in a portal by default
([#2060](#2060))
([95960f7](95960f7))

### Features

- **Alert:** add shorthand sizes
([#1995](#1995))
([868d214](868d214))
- **Box:** add shorthand sizes
([#2048](#2048))
([05901c0](05901c0))
- **Checkbox:** add shorthand sizes
([#2030](#2030))
([e2ca09d](e2ca09d))
- **Chips:** add shorthand sizes
([#2007](#2007))
([318d1ee](318d1ee))
- **Combobox:** add shorthand sizes
([#2029](#2029))
([f1ef9fe](f1ef9fe))
- **DropdownMenu:** add shorthand sizes
([#2021](#2021))
([cf17310](cf17310))
- **ErrorMessage:** add shorthand sizes
([#2019](#2019))
([c511c59](c511c59))
- **Heading:** add shorthand sizes
([#1997](#1997))
([265a3c7](265a3c7))
- **HelpText:** add shorthand sizes
([#2014](#2014))
([ad97311](ad97311))
- **Ingress:** add shorthand sizes
([#2020](#2020))
([62caef5](62caef5))
- **Label:** add shorthand sizes
([#1999](#1999))
([919c43c](919c43c))
- **List:** add shorthand sizes
([#2009](#2009))
([7f694e0](7f694e0))
- **NativeSelect:** add shorthand sizes
([#2033](#2033))
([1d494d1](1d494d1))
- **Pagination:** add shorthand sizes
([#2034](#2034))
([1c549b7](1c549b7))
- **Paragraph:** add shorthand sizes
([#1996](#1996))
([72a7824](72a7824))
- **Popover:** add shorthand sizes
([#2006](#2006))
([6637c52](6637c52))
- **Radio:** add shorthand sizes
([#2036](#2036))
([20278fa](20278fa))
- **Search:** add shorthand sizes
([#2028](#2028))
([d8fc81d](d8fc81d))
- **Spinner:** add shorthand sizes
([#2000](#2000))
([b18eb98](b18eb98))
- **Switch:** add shorthand sizes
([#2027](#2027))
([bd5160b](bd5160b))
- **Table:** add shorthand sizes
([#2016](#2016))
([50cbb8e](50cbb8e))
- **Tabs:** add shorthand sizes
([#2012](#2012))
([806125d](806125d))
- **Tag:** add shorthand sizes
([#2017](#2017))
([405f55d](405f55d))
- **Textarea:** add shorthand sizes
([#2031](#2031))
([5932d5e](5932d5e))
- **Textfield:** add shorthand sizes
([#2018](#2018))
([9c52938](9c52938))
- **ToggleGroup:** add shorthand sizes
([#2011](#2011))
([44f9abd](44f9abd))

#
[0.61.0](https://github.com/digdir/designsystemet/compare/@digdir/[email protected]...@digdir/[email protected])
(2024-05-16)

### Bug Fixes

- **Combobox:** Show all options in single mode when a value is selected
([#1983](#1983))
([ac82b50](ac82b50))

### Features

- **Button:** add shorthand sizes
([#1986](#1986))
([38a5232](38a5232))

#
[0.60.0](https://github.com/digdir/designsystemet/compare/@digdir/[email protected]...@digdir/[email protected])
(2024-05-14)

### Bug Fixes

- **Combobox:** Improve performance
([#1771](#1771))
([18cdd17](18cdd17))
- **Modal:** fix close button position
([#1877](#1877))
([c866710](c866710))

### Features

- **Box:** Remove deprecated `as` prop
([#1896](#1896))
([59dd231](59dd231))
- **Button:** Remove deprecated `as` prop
([#1894](#1894))
([c346203](c346203))
- **Card:** Remove deprecated `as` prop
([#1897](#1897))
([17ef8c6](17ef8c6))
- **DropdownMenuItem:** Remove deprecated `as` prop
([#1895](#1895))
([2f705bb](2f705bb))
- **ErrorMessage:** Remove deprecated `as` prop
([#1899](#1899))
([b37584a](b37584a))
- **Heading:** Remove deprecated `as` prop
([#1900](#1900))
([685e438](685e438))
- **Ingress:** Remove deprecated `as` prop
([#1903](#1903))
([1139b31](1139b31))
- **Label:** Remove deprecated `as` prop
([#1904](#1904))
([a1469e4](a1469e4))
- **Link:** Remove deprecated `as` prop
([#1898](#1898))
([f037bd2](f037bd2))
- **Paragraph:** Remove deprecated `as` prop
([#1905](#1905))
([aa81f5a](aa81f5a))
- **Paragraph:** Remove deprectated `short` prop
([#1891](#1891))
([e1213b0](e1213b0))

## @digdir/[email protected]

### Patch Changes

-
[`2d1da9a`](2d1da9a)
Thanks [@mimarz](https://github.com/mimarz)! - Testing snapshot release

All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit
guidelines.

#
[1.0.0-rc.6](https://github.com/digdir/designsystemet/compare/@digdir/[email protected]...@digdir/[email protected])
(2024-06-11)

### Features

- 🎨 V1 Release candidate
([#1849](#1849))
([917ac1f](917ac1f))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Barsnes Barsnes Awaiting requested review from Barsnes Barsnes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combobox - Not possible to close the combobox by clicking on the arrow button
1 participant
@mimarz