Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Grid 12 #11

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update Grid 12 #11

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d2cf8d
Add update-grid proposal
elisechant Oct 7, 2021
ba9c314
update
elisechant Oct 7, 2021
eadf187
update
elisechant Oct 7, 2021
142e525
format
elisechant Oct 7, 2021
5d64848
fix links
elisechant Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions RFC-by-stage/1-approved/update-grid.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
---
Status: `Proposal` # Please do not change this.
Implementer: # It will be changed upon merging and as it moves through the RFC stages
---

# Update Grid 12 to use Flexbox

## The issue to be solved

Grid 12 is how the Design System does layout.

Grid 12 was based on Bootstrap 3 (I think, it might be v4) and uses the box model to handle layout. Bootstrap v3 Grid docs here https://getbootstrap.com/docs/3.3/css/#grid and v4 here https://getbootstrap.com/docs/4.0/layout/grid/.

However, Bootstrap is now at v5.1 and has moved to Flexbox, see https://getbootstrap.com/docs/5.1/layout/grid/, which is a good signal that we should too.

There are increased benefits of using Flexbox - such as easier vertical centering, which would add capability to Grid 12.
Comment on lines +10 to +16
Copy link

@liamfiddler liamfiddler Oct 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating this proposal @elisechant 🙏

If we intend to continue maintaining & supporting Grid 12 internals (perhaps to offer an easy transition for people already relying on those classes in the old design system) flexbox sounds like a good idea 👍

But I wonder if we still need Grid 12 now CSS grid is more mature. Perhaps we could also consider deprecating Grid 12 internals and using CSS grid instead of flexbox?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.

The key reason for suggesting Flexbox is that it would be an easy port from Bootstrap. Although I agree, that CSS Grid seems more appropriate.


A downside is that this would limit browser compatibility, however, Flexbox is highly supported by browsers nowadays, see https://caniuse.com/flexbox.
elisechant marked this conversation as resolved.
Show resolved Hide resolved

## A short description of the desired outcome or solution

I propose we keep a similar API design, but replace the internals of Grid 12 to use Flexbox.

## Technical details

- Rewrite Grid 12 module