Update Grid 12 #11
Open
Update Grid 12 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamfiddler
reviewed
Oct 8, 2021
Comment on lines
+10
to
+16
| Grid 12 is how the Design System does layout. | ||
|
|
||
| Grid 12 was based on Bootstrap 3 (I think, it might be v4) and uses the box model to handle layout. Bootstrap v3 Grid docs here https://getbootstrap.com/docs/3.3/css/#grid and v4 here https://getbootstrap.com/docs/4.0/layout/grid/. | ||
|
|
||
| However, Bootstrap is now at v5.1 and has moved to Flexbox, see https://getbootstrap.com/docs/5.1/layout/grid/, which is a good signal that we should too. | ||
|
|
||
| There are increased benefits of using Flexbox - such as easier vertical centering, which would add capability to Grid 12. |
There was a problem hiding this comment.
Thank you for creating this proposal @elisechant 🙏
If we intend to continue maintaining & supporting Grid 12 internals (perhaps to offer an easy transition for people already relying on those classes in the old design system) flexbox sounds like a good idea 👍
But I wonder if we still need Grid 12 now CSS grid is more mature. Perhaps we could also consider deprecating Grid 12 internals and using CSS grid instead of flexbox?
There was a problem hiding this comment.
Yeah.
The key reason for suggesting Flexbox is that it would be an easy port from Bootstrap. Although I agree, that CSS Grid seems more appropriate.
liamfiddler
reviewed
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.