Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Docker image for P2P #224

Merged
merged 9 commits into from
Aug 2, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
FROM --platform=$BUILDPLATFORM node:18 as build

ARG BUILDPLATFORM=linux/amd64

WORKDIR /app

ENV HUSKY=0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disable husky precheck


RUN git clone https://github.com/deriv-com/p2p.git .

RUN npm install

ENV NODE_ENV=production
RUN npm run build

FROM --platform=$BUILDPLATFORM node:lts-alpine3.20
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to multi-stage build to use node:lts for production environment


RUN npm install -g serve

COPY --from=build /app/dist /dist

EXPOSE 4000

ENTRYPOINT ["serve"]

CMD ["-s", "dist", "-l", "4000"]
229 changes: 224 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -107,5 +107,8 @@
"typescript": "^5.2.2",
"vite-plugin-html-config": "^1.0.11",
"vite-plugin-sass": "^0.1.0"
},
"optionalDependencies": {
"@rollup/rollup-linux-x64-gnu": "4.9.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Q] why is this needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may use FROM --platform=linux/xxxxx

Copy link
Contributor Author

@adrienne-deriv adrienne-deriv Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to support linux/amd64 builds:
Screenshot 2024-08-01 at 8 21 50 PM

Tried specifying platform as linux/arm64, it still needs the additional dependencies for @rollup/rollup-linux-arm64-gnu:
Screenshot 2024-08-01 at 8 29 43 PM

}
}
Loading