Created Docker image for P2P #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienne-deriv
requested review from
ali-hosseini-deriv,
yashim-deriv,
azmib-developer and
farrah-deriv
as code owners
Pull Request Test Coverage Report for Build 10209150191Details
💛 - Coveralls |
amam-deriv
reviewed
Aug 1, 2024
| @@ -107,5 +107,8 @@ | |||
| "typescript": "^5.2.2", | |||
| "vite-plugin-html-config": "^1.0.11", | |||
| "vite-plugin-sass": "^0.1.0" | |||
| }, | |||
| "optionalDependencies": { | |||
| "@rollup/rollup-linux-x64-gnu": "4.9.5" | |||
There was a problem hiding this comment.
may use FROM --platform=linux/xxxxx
There was a problem hiding this comment.
This is needed to support linux/amd64 builds:
Tried specifying platform as linux/arm64, it still needs the additional dependencies for @rollup/rollup-linux-arm64-gnu:
adrienne-deriv
commented
Aug 1, 2024
|
|
||
| WORKDIR /app | ||
|
|
||
| ENV HUSKY=0 |
There was a problem hiding this comment.
Disable husky precheck
adrienne-deriv
commented
Aug 1, 2024
| ENV NODE_ENV=production | ||
| RUN npm run build | ||
|
|
||
| FROM --platform=$BUILDPLATFORM node:lts-alpine3.20 |
There was a problem hiding this comment.
Change to multi-stage build to use node:lts for production environment
amam-deriv
approved these changes
Aug 2, 2024
|
Preview Link: https://deploy-docker.p2p-standalone.pages.dev
|
farrah-deriv
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.