Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deriv_auth_ui): add option to enable/disable forgot password & create account #352

Merged
Show file tree
Hide file tree
Changes from 44 commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
2c4e503
deps: update deriv_auth_ui dependencies
sahani-deriv Oct 25, 2023
4577f69
deps: update deriv_theme in deriv_ui
sahani-deriv Oct 26, 2023
a991d47
wip: auth-ui-update
sahani-deriv Oct 26, 2023
1720d56
added invalidresidence errror mapping for social login
Oct 9, 2023
6818ff3
feat: add deriv auth error state handler
sahani-deriv Oct 26, 2023
b791015
feat: add auth error state handler in sign up page
sahani-deriv Oct 26, 2023
737ed84
feat: add auth error state handler in set password page
sahani-deriv Oct 26, 2023
05c12d5
refactor: auth state handling in signup and set password page
sahani-deriv Oct 27, 2023
f8f9517
feat: add social button flag
sahani-deriv Oct 27, 2023
7cc2394
feat: country consent added in country_selection_layout
sahani-deriv Oct 30, 2023
e5abb7d
deps: remove relative path
sahani-deriv Oct 30, 2023
84e2099
refactor: auth state handler
sahani-deriv Oct 30, 2023
aa5fd05
test: country selection cubit test
sahani-deriv Oct 30, 2023
1b29409
test: auth state handler
sahani-deriv Oct 31, 2023
185928c
feat: add gesture detector in get started layout
sahani-deriv Oct 31, 2023
afb1989
feat: reset pass success page
sahani-deriv Oct 31, 2023
4ba23ea
docs: update documentation based on latest changes
sahani-deriv Oct 31, 2023
c2c7a80
refactor: add eof and remove deprecated lint
sahani-deriv Nov 2, 2023
e65d758
refactor: make countries non-nullable
sahani-deriv Nov 6, 2023
e88f633
refactor: deriv country selection cubit
sahani-deriv Nov 10, 2023
5b0d5f0
refactor: deriv country selection cubit
sahani-deriv Nov 10, 2023
5e6ddfb
ci: integrate github actions and setup melos (#328)
sahani-deriv Nov 16, 2023
b05830a
chore: rename `AuthStateListener`
sahani-deriv Nov 17, 2023
cac78e4
fix: change color to general
sahani-deriv Nov 17, 2023
411b211
fix: reset password button alignment
sahani-deriv Nov 17, 2023
086fc63
fix: add missing ok label in referal dialog
sahani-deriv Nov 17, 2023
1f134af
merge: with dev
sahani-deriv Nov 17, 2023
016f390
feat: add flag for social login
sahani-deriv Nov 17, 2023
d782c86
fix: spacing after social flag
sahani-deriv Nov 17, 2023
f48c322
chore: add auth ui regex to deriv ui
sahani-deriv Nov 20, 2023
b2c282e
Merge pull request #314 from sahani-deriv/auth-ui-update
ahrar-deriv Nov 20, 2023
ce8d202
feat: [MOBC-608] auth ui setting page (#320)
ahrar-deriv Nov 21, 2023
829f78f
chore: merge master to dev (#334)
ahrar-deriv Nov 21, 2023
11f667c
add invalidate and copyValuesFrom to AbstractEMAIndicator (#331)
ramin-deriv Nov 22, 2023
53ffa34
ci: automated versioning github actions and updated ref (#338)
sahani-deriv Nov 27, 2023
a7242c8
refactor(deriv_env): make package independent of env file (#318)
ramin-deriv Nov 27, 2023
2cdb323
chore: [MOBC-632] remove commit hash ci (#340)
ahrar-deriv Nov 27, 2023
0758010
chore(version): bump version and update changelog (#342)
mobile-apps-deriv Nov 27, 2023
c8e27e0
chore(deriv_auth_ui): remove unecessary deps from example (#343)
sahani-deriv Nov 28, 2023
bf62582
feat: Ayaan/Added margins 112 and 164 (#319)
ayaan-deriv Nov 28, 2023
2eaddf5
chore(release): publish packages (#344)
mobile-apps-deriv Nov 29, 2023
36a0c1f
refactor(deriv_auth_ui): [MOBC-629] Adding semantics to UI components…
ernest-deriv Nov 29, 2023
1d842a8
chore(release): publish packages (#345)
mobile-apps-deriv Nov 29, 2023
4d212e0
add option to enable/disable forgot password & create account
anas-deriv Dec 8, 2023
37a6391
fix comment from @sahani-deriv
anas-deriv Dec 13, 2023
7603506
update dependencies
anas-deriv Dec 15, 2023
e644487
Merge remote-tracking branch 'upstream/master' into Anas/enable-disab…
anas-deriv Dec 15, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
172 changes: 172 additions & 0 deletions .github/GIT_RULES.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,172 @@
## Commit Rules:

This commits rules is set to ensure all the developers follows a uniform way of writing commits so that it is easy to read the changes made and also automate versioning.
The commits are based on [conventional commit](https://www.conventionalcommits.org/en/v1.0.0/) which is a widely followed convention for commits. While writing a commit message to any changes made to code base, make sure it reflects the changes and follows the conventions i.e:

```
change_type(package_name): short description/subject line...

Long Description...
```

Here,

change_type means the type of changes like `feat`,`fix` and so on.

package_name means which packages this changes is for. This is optional.

short discription/subject line means about the changes

Long Description are optional. Add it if its required to reflect the changes in more detail.

For eg:

Lets say the changes is about implementing a new feature which is about new social login mechanism in `deriv_auth` package.

```
feat(deriv_auth): add UI for sign in page

- create reusable text field using global app theme
- add bloc for sign in logic implementation
- add google services for authentication
```
### Breaking Changes Indicator
Breaking changes should be indicated by an `!` before the `:` in the subject line e.g. `feat(api)!: remove status endpoint`
* Is an **optional** part of the format

More changes types:

| Changes Types | Meaning | Description |
| ------------- | -------------------------- | ------------------------------------------------------------------------------------------------------------- |
| feat | Features | A new feature |
| fix | Bug Fixes | A bug fix |
| chore | Chores | Other changes that don’t modify src or test files |
| docs | Docume­ntation | Docume­ntation only changes |
| revert | Reverts | Reverts a previous commit |
| refactor | Code Refact­oring | A code change that neither fixes a bug nor adds a feature |
| test | Tests | Adding missing tests or correcting existing tests |
| style | Styles | Changes that do not affect the meaning of the code (white­ -space, format­ting, missing semi-c­olons, etc) |
| perf | Perfor­mance Improv­ements | A code change that improves perfor­mance |
| build | Builds | Changes that affect the build system or external depend­encies (example scopes: gulp, broccoli, npm) |
| ci | Continuous Integr­ations | Changes to our CI config­uration files and scripts (example scopes: Travis, Circle, Browse­rStack, SauceLabs) |

Optional: If you would like to pre populate your commit box with the commit template then you can do it by adding `.gitmessage` inside `.github` folder to commit template for that project with the following command.(Note: This won't work if you write commit via terminal.)

`git config commit.template "YOUR_PROJECT_PATH/.github/.gitmessage"`

### Examples
* ```
feat: add email notifications on new direct messages
```
* ```
feat(shopping cart): add the amazing button
```
* ```
feat!: remove ticket list endpoint

refers to JIRA-1337

BREAKING CHANGES: ticket enpoints no longer supports list all entites.
```
* ```
fix(api): handle empty message in request body
```
* ```
fix(api): fix wrong calculation of request body checksum
```
* ```
fix: add missing parameter to service call

The error occurred because of <reasons>.
```
* ```
perf: decrease memory footprint for determine uniqe visitors by using HyperLogLog
```
* ```
build: update dependencies
```
* ```
build(release): `bump version to 1.0.0
```
* ```
refactor: implement fibonacci number calculation as recursion
```
* ```
style: remove empty line
```
## PR Rules:

This Rules is set to create a uniform way of submitting Pull requests where all the necessary information for the changes are listed in the title, or description. There is a standard template for creating PR. When you are creating a PR to any repo always make sure:

- you have titled it following conventional pattern and also included all the necessary information in it.
for eg:
Title: `feat(deriv_auth): [MOBC-299] Add ability to sign in with google`

Here,</br> The title defines:

- what type the changes/PR is about like feature, bug fixes, documentations, refactor. </br>
- which package/app is this PR for.(optional) </br>
- the clickup card id - short title that describes the changes </br>

- you have added detailed description that gives enough information about the PR.
- you have commits only relevant to your changes and not other's commit which shouldn't be there.

Also, it is always better to squash commits that are only relevant to any particular PR. Such as changes requested through PR review. If these changes does not reflects any really meaning or value in the main project history then it is always better to squash such commits into one. It helps to maintain a clean commit history.

**The template looks something like this:**

<!-- Please refer to this [guide](https://github.com/regentmarkets/flutter-deriv-packages/blob/master/.github/GIT_RULES.md#pr-rules) for any confusion while creating the PR -->

**Clickup link:** <!-- Add your clickup link here, Remove this line if this PR is not for a task -->
**Fixes issue:** #<!-- Issue number here, Remove this line if this PR isn't related to any issue -->

This PR contains the following changes:

<!-- Provide a description or list of changes -->

- [ ] ✨ New feature (non-breaking change which adds functionality)
- [ ] 🛠️ Bug fix (non-breaking change which fixes an issue)
- [ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
- [ ] 🧹 Code refactor
- [ ] ✅ Build configuration change
- [ ] 📝 Documentation
- [ ] 🗑️ Chore

### Developers Note (Optional)

<!-- REMOVE THIS SECTION IF IT IS NOT NEEDED.>

<!-- Add the reason of making changes in this approach so that it will be helpful to reviewers while reviewing it. -->

## Pre-launch Checklist (For PR creator)

As a creator of this PR:

<!-- Put an `x` in all the boxes that apply ([x]) -->

- [ ] ✍️ I have included clickup id and package/app_name in the PR title. <!-- Find the guide [here](https://github.com/regentmarkets/flutter-deriv-packages/blob/master/.github/GIT_RULES.md#pr-rules) -->
- [ ] 👁️ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
- [ ] ⚒️ I have fixed any errors/warnings shown by the analyzer/linter.
- [ ] 📝 I have added documentation, comments and logging wherever required.
- [ ] 🧪 I have added necessary tests for these changes.
- [ ] 🔎 I have ensured all existing tests are passing.

## Reviewers

<!-- Tag the reviewers of this PR -->

## Pre-launch Checklist (For Reviewers)

As a reviewer I ensure that:

- [ ] ✴️ This PR follows the standard PR template.
- [ ] ✴️ The information in this PR properly reflects the code changes.
- [ ] 🧪 All the necessary tests for this PR's are passing.

## Pre-launch Checklist (For QA)

- [ ] 👌 It passes the acceptance criteria.

## Pre-launch Checklist (For Maintainer)

- [ ] [MAINTAINER_NAME] I make sure this PR fulfills its purpose.
55 changes: 55 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
<!-- Please refer to this [guide](https://github.com/regentmarkets/flutter-deriv-packages/blob/master/.github/GIT_RULES.md#pr-rules) for any confusion while creating the PR -->

**Clickup link:** <!-- Add your clickup link here, Remove this line if this PR is not for a task -->
**Fixes issue:** #<!-- Issue number here, Remove this line if this PR isn't related to any issue -->

This PR contains the following changes:

<!-- Provide a description or list of changes -->

- [ ] ✨ New feature (non-breaking change which adds functionality)
- [ ] 🛠️ Bug fix (non-breaking change which fixes an issue)
- [ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
- [ ] 🧹 Code refactor
- [ ] ✅ Build configuration change
- [ ] 📝 Documentation
- [ ] 🗑️ Chore

### Developers Note (Optional)

<!-- REMOVE THIS SECTION IF IT IS NOT NEEDED.>

<!-- Add the reason of making changes in this approach so that it will be helpful to reviewers while reviewing it. -->

## Pre-launch Checklist (For PR creator)

As a creator of this PR:

<!-- Put an `x` in all the boxes that apply ([x]) -->

- [ ] ✍️ I have included clickup id and package/app_name in the PR title. <!-- Find the guide [here](https://github.com/regentmarkets/flutter-deriv-packages/blob/master/.github/GIT_RULES.md#pr-rules) -->
- [ ] 👁️ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
- [ ] ⚒️ I have fixed any errors/warnings shown by the analyzer/linter.
- [ ] 📝 I have added documentation, comments and logging wherever required.
- [ ] 🧪 I have added necessary tests for these changes.
- [ ] 🔎 I have ensured all existing tests are passing.

## Reviewers

<!-- Tag the reviewers of this PR -->

## Pre-launch Checklist (For Reviewers)

As a reviewer I ensure that:

- [ ] ✴️ This PR follows the standard PR template.
- [ ] 🪩 The information in this PR properly reflects the code changes.
- [ ] 🧪 All the necessary tests for this PR's are passing.

## Pre-launch Checklist (For QA)

- [ ] 👌 It passes the acceptance criteria.

## Pre-launch Checklist (For Maintainer)

- [ ] [MAINTAINER_NAME] I make sure this PR fulfills its purpose.
44 changes: 44 additions & 0 deletions .github/workflows/all_packages.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
name: all_packages

on:
push:
branches:
- master
- dev
pull_request:
branches:
- "*"

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
analyze_and_test:
runs-on: ubuntu-latest
steps:
- name: Git Checkout
uses: actions/checkout@v4

- name: Setup Flutter
uses: subosito/flutter-action@v2
with:
channel: "stable"
flutter-version: "3.10.2"
cache: true

- name: Set SSH Key
uses: webfactory/[email protected]
with:
ssh-private-key: ${{secrets.SSH_PRIVATE_KEY}}

- name: Install Melos and run pub get
uses: bluefireteam/melos-action@v1
with:
melos-version: "3.0.1"

- name: Run Analyze
run: melos run analyze

- name: Run Test
run: melos run test --no-select
19 changes: 19 additions & 0 deletions .github/workflows/pr_title.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: pr_title

on:
pull_request_target:
types:
- opened
- edited
- synchronize

permissions:
pull-requests: read

jobs:
validate:
runs-on: ubuntu-latest
steps:
- uses: amannn/action-semantic-pull-request@v5
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
55 changes: 55 additions & 0 deletions .github/workflows/version.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
name: version

on:
pull_request:
types:
- closed
branches:
- dev

permissions:
contents: write
pull-requests: write

jobs:
version_and_tag:
runs-on: ubuntu-latest
if: github.event.pull_request.merged == true && !contains(github.event.pull_request.title, 'chore(version)')
steps:
- name: Git Checkout
uses: actions/checkout@v4
with:
ssh-key: ${{ secrets.SSH_PRIVATE_KEY }}
fetch-depth: 0

- name: Setup Git User
uses: fregante/setup-git-user@v2

- name: Setup Flutter
uses: subosito/flutter-action@v2
with:
channel: "stable"
flutter-version: "3.10.2"
cache: true

- name: Setup Melos
uses: bluefireteam/melos-action@v3
with:
melos-version: "3.2.0"
run-bootstrap: false

- name: Create git tag based on version
# only consider changes from the commit mentioned below
run: melos version --all --yes

- name: Push tag
run: git push --tags
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Create Pull Request on updated changelog and pubspec file.
uses: peter-evans/create-pull-request@v5
with:
token: ${{ secrets.PAT }}
title: "chore(version): bump version and update changelog"
base: dev
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,11 @@ lib/basic_api/generated/*.json
.flutter-plugins
.packages
.pub-cache/
pubspec.lock
.pub/
/build/
coverage/
/packages/**/pubspec_overrides.yaml
/packages/**/pubspec.lock


gradlew.bat
Expand Down
Loading
Loading