Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deriv_auth_ui): add option to enable/disable forgot password & create account #352

Conversation

anas-deriv
Copy link
Contributor

@anas-deriv anas-deriv commented Dec 8, 2023

Clickup link: https://app.clickup.com/t/20696747/P2PS-2087
Fixes issue: the forgot password & create account now have options

This PR contains the following changes:

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Developers Note (Optional)

Pre-launch Checklist (For PR creator)

As a creator of this PR:

  • ✍️ I have included clickup id and package/app_name in the PR title.
  • 👁️ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
  • ⚒️ I have fixed any errors/warnings shown by the analyzer/linter.
  • 📝 I have added documentation, comments and logging wherever required.
  • 🧪 I have added necessary tests for these changes.
  • 🔎 I have ensured all existing tests are passing.

Reviewers

Pre-launch Checklist (For Reviewers)

As a reviewer I ensure that:

  • ✴️ This PR follows the standard PR template.
  • 🪩 The information in this PR properly reflects the code changes.
  • 🧪 All the necessary tests for this PR's are passing.

Pre-launch Checklist (For QA)

  • 👌 It passes the acceptance criteria.

Pre-launch Checklist (For Maintainer)

ahrar-deriv and others added 14 commits November 20, 2023 17:37
* feat: setting page

* fix: depricated issues

* fix: change package_info_plus to match packages

* fix: future void callback

* refactor: move regex_helper func to deriv_ui

* fix: remove sahani repo from yaml files

* fix: deriv_auth_ui pubspec

* fix: remove appEnv related to deriv ez

as deriv ez is removed from production we dont need to include it in this package anymore

* fix: revert back the appEnv and change the comment
* add update_checker package

* add Readme

* add comments

* update documentation

* apply suggestions from PR review

* update deps

* update flutter_bloc package

* Revert "update flutter_bloc package"

This reverts commit 7188a184363fafe0601f0fa904a3f42937e40978.

* Update packages/update_checker/lib/update_info.dart

Co-authored-by: abed-binary <[email protected]>

* update bloc library to 6.0.1

* remove markseen

* remove unnecessary statements

* restore UpdateCheckMarkSeen

* add UpdateCheckDismiss

* push update_checker changes

* Update web_socket_test.dart

* chore: add pull request template with git rules

* chore: pull request update git_rules.md

---------

Co-authored-by: Suyash Mohan <[email protected]>
Co-authored-by: Suyash Mohan <[email protected]>
Co-authored-by: abed-binary <[email protected]>
Co-authored-by: Morteza Tavanarad <[email protected]>
Co-authored-by: ramin-deriv <[email protected]>
Co-authored-by: ramin-deriv <[email protected]>
Co-authored-by: WAQAS YOUNAS <[email protected]>
Co-authored-by: WAQAS YOUNAS <[email protected]>
* deps: update dependencies

update dependencies deriv_ui

update dependencies part 1

update dependencies deriv_auth_ui

* deps: push melos pubspec.lock

* chore: publish packages

chore(release): publish packages

- [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]+1
 - [email protected]

chore(release): publish packages

- [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]+1
 - [email protected]
 - [email protected]

chore(release): publish packages

- [email protected]

chore(release): publish packages

- [email protected]

* chore: clean changelog

* chore: revert changelog changes

* chore: change auth ui example app ref

* ci: git actions for versioning
* get the env file content from outside

* make Env class not being singleton

* create EnvLoader class

* fix the tests

* bring back the removed test case

* update the initialize doc

* export classes need to be used by outside

* export BaseEnv class as well

* format deriv_env.dart

* swape names for Env and EnvLoader to reduce the amount of change in the apps using this packagew

* handle exception in bool type

* remove duplicate lint rules

* define common values as variable in env_test.dart

* update README.md file

* remove breaking change by making the laod method deprecated

* Update CHANGELOG.md

* udpate README.md file

* refactor: Improve flexibility by removing dependency to env file
- **Deprecation:** The `load` method is deprecated; it is recommended to use the new `initialize` method for improved flexibility. The `load` method will still function but may be removed in future releases.
- Introduced a new method `initialize` to handle initialization without requiring an env file directly.
- Improved package flexibility by removing the strict dependency on an env file for test environments.
- [email protected]+1

Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
* Add dimens 112 and 164

* Update dimens.dart
- [email protected]
 - [email protected]+1
 - [email protected]+1
 - [email protected]+1
 - [email protected]+1
 - [email protected]

Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
… (#321)

* chore(deriv_auth_ui):Adding semantics to UI components

* chore(deriv_auth_ui):Adding semantics to UI components, fixes based on review comments

* chore(deriv_auth_ui):Adding explicitChildNodes: true to Semantics Widgets
- [email protected]+2
 - [email protected]+2

Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
@anas-deriv anas-deriv self-assigned this Dec 8, 2023
@anas-deriv anas-deriv changed the title add option to enable/disable forgot password & create account refactor: add option to enable/disable forgot password & create account Dec 8, 2023
@sahani-deriv
Copy link
Contributor

sahani-deriv commented Dec 13, 2023

@anas-deriv please change your pr title from refactor:.... to feat(deriv_auth_ui):.... I think since you have added new capabilities in the package it should be feat.

@anas-deriv anas-deriv changed the title refactor: add option to enable/disable forgot password & create account feat(deriv_auth_ui): add option to enable/disable forgot password & create account Dec 13, 2023
@anas-deriv anas-deriv changed the base branch from dev to master December 13, 2023 07:01
…le-showing-forgot-pass-and-create-account

# Conflicts:
#	.github/GIT_RULES.md
#	.github/workflows/all_packages.yaml
#	.github/workflows/pr_title.yaml
#	.github/workflows/version.yaml
#	CHANGELOG.md
#	packages/deriv_auth_ui/CHANGELOG.md
#	packages/deriv_auth_ui/lib/src/features/login/layouts/deriv_login_layout.dart
#	packages/deriv_auth_ui/pubspec.yaml
#	packages/deriv_date_range_picker/CHANGELOG.md
#	packages/deriv_date_range_picker/pubspec.yaml
#	packages/deriv_env/CHANGELOG.md
#	packages/deriv_env/pubspec.yaml
#	packages/deriv_expandable_bottom_sheet/CHANGELOG.md
#	packages/deriv_expandable_bottom_sheet/pubspec.yaml
#	packages/deriv_numpad/CHANGELOG.md
#	packages/deriv_numpad/pubspec.yaml
#	packages/deriv_theme/CHANGELOG.md
#	packages/deriv_theme/pubspec.yaml
#	packages/deriv_ui/CHANGELOG.md
#	packages/deriv_ui/pubspec.yaml
@sahani-deriv sahani-deriv merged commit 1db8715 into deriv-com:master Dec 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants