Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 12시 이후 미션 인증 안되는 에러 처리 #380

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

char-yb
Copy link
Member

@char-yb char-yb commented Apr 2, 2024

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • 인증 했을때 시작 시간이랑 종료 시간이랑 24시간 비교하는 로직 추가

📝 참고사항

📚 기타

@char-yb char-yb added 🥇 P1 급하고 꼭 필요한 이슈 🐛 bug/error 버그 및 에러 픽스 labels Apr 2, 2024
@char-yb char-yb added this to the 4차 스프린트 milestone Apr 2, 2024
@char-yb char-yb self-assigned this Apr 2, 2024
@char-yb char-yb requested review from kdomo and uwoobeat as code owners April 2, 2024 14:29
@char-yb char-yb linked an issue Apr 2, 2024 that may be closed by this pull request
Copy link
Member

@kdomo kdomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅LGTM✅

@@ -65,6 +68,12 @@ public MissionRecordCreateResponse createMissionRecord(MissionRecordCreateReques
return MissionRecordCreateResponse.from(createdMissionRecord.getId());
}

private void validateMissionRecordDurationOverTime(long diffHour) {
if (diffHour >= 24) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macig number보다 더 좋은 변수가 있지 않을까 싶아욤

Copy link

sonarqubecloud bot commented Apr 3, 2024

@char-yb char-yb merged commit 50e5bcb into develop Apr 3, 2024
2 checks passed
@char-yb char-yb added the merged 머지된 PR label Apr 4, 2024
@char-yb char-yb changed the title 🐛 12시 이후 미션 인증 안되는 에러 처리 fix 12시 이후 미션 인증 안되는 에러 처리 Apr 4, 2024
@char-yb char-yb changed the title fix 12시 이후 미션 인증 안되는 에러 처리 fix: 12시 이후 미션 인증 안되는 에러 처리 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug/error 버그 및 에러 픽스 merged 머지된 PR 🥇 P1 급하고 꼭 필요한 이슈
Projects
Status: 완료
Development

Successfully merging this pull request may close these issues.

🐛 12시 이후 미션 인증 안되는 에러 처리
2 participants