🐛 12시 이후 미션 인증 안되는 에러 처리 (#380)

* fix: 미션 인증 초과 validate * fix: spotlessApply * fix: magic number 상수화 * fix: 에러 코드 변경 * fix: spotlessApply
depromeet · Apr 3, 2024 · 50e5bcb · 50e5bcb
1 parent 0c1035f
commit 50e5bcb
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/src/main/java/com/depromeet/domain/missionRecord/application/MissionRecordService.java b/src/main/java/com/depromeet/domain/missionRecord/application/MissionRecordService.java
@@ -31,13 +31,17 @@
 public class MissionRecordService {
     private static final int EXPIRATION_TIME = 10;
     private static final int DAYS_ADJUSTMENT = 1;
+    private static final long MAX_DURATION_HOUR = 24;
 
     private final MemberUtil memberUtil;
     private final MissionRepository missionRepository;
     private final MissionRecordRepository missionRecordRepository;
     private final MissionRecordTtlRepository missionRecordTtlRepository;
 
     public MissionRecordCreateResponse createMissionRecord(MissionRecordCreateRequest request) {
+        long diffHour = Duration.between(request.startedAt(), request.finishedAt()).toHours();
+        validateMissionRecordDurationOverTime(diffHour);
+
         final Mission mission = findMissionById(request.missionId());
         final Member member = memberUtil.getCurrentMember();
 
@@ -65,6 +69,12 @@ public MissionRecordCreateResponse createMissionRecord(MissionRecordCreateReques
         return MissionRecordCreateResponse.from(createdMissionRecord.getId());
     }
 
+    private void validateMissionRecordDurationOverTime(long diffHour) {
+        if (diffHour >= MAX_DURATION_HOUR) {
+            throw new CustomException(ErrorCode.MISSION_RECORD_DURATION_OVERTIME);
+        }
+    }
+
     private void validateMissionRecordExistsToday(Long missionId) {
         if (missionRecordRepository.isCompletedMissionExistsToday(missionId)) {
             throw new CustomException(ErrorCode.MISSION_RECORD_ALREADY_EXISTS_TODAY);

diff --git a/src/main/java/com/depromeet/global/error/exception/ErrorCode.java b/src/main/java/com/depromeet/global/error/exception/ErrorCode.java
@@ -44,6 +44,7 @@ public enum ErrorCode {
     MISSION_RECORD_UPLOAD_STATUS_IS_NOT_PENDING(
             HttpStatus.BAD_REQUEST, "미션 기록의 이미지 업로드 상태가 PENDING이 아닙니다."),
     MISSION_RECORD_ALREADY_EXISTS_TODAY(HttpStatus.BAD_REQUEST, "오늘 이미 작성 된 미션 기록이 존재합니다."),
+    MISSION_RECORD_DURATION_OVERTIME(HttpStatus.CONFLICT, "가능한 미션 인증 시간이 초과되었습니다."),
 
     // Follow
     FOLLOW_TARGET_MEMBER_NOT_FOUND(HttpStatus.NOT_FOUND, "타겟 유저을 찾을 수 없습니다."),

diff --git a/src/test/java/com/depromeet/domain/missionRecord/application/MissionRecordServiceTest.java b/src/test/java/com/depromeet/domain/missionRecord/application/MissionRecordServiceTest.java
@@ -71,6 +71,17 @@ void setUp() {
         missionRepository.save(mission);
     }
 
+    @Test
+    void 하루가_지나_미션_인증한_경우_에러를_발생시킨다() {
+        // exception
+        assertThrows(
+                CustomException.class,
+                () ->
+                        missionRecordService.createMissionRecord(
+                                new MissionRecordCreateRequest(
+                                        mission.getId(), now, now.plusDays(1), 20, 0)));
+    }
+
     @Test
     void 진행중인_미션기록을_삭제한다() {
         // given