-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 유저 팔로잉/팔로워 목록 조회 API #274
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
src/main/java/com/depromeet/domain/follow/dto/response/FollowListResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
package com.depromeet.domain.follow.dto.response; | ||
|
||
import com.depromeet.domain.member.dto.response.MemberSearchResponse; | ||
import java.util.List; | ||
|
||
public record FollowListResponse( | ||
String targetNickname, | ||
List<MemberSearchResponse> followingList, | ||
List<MemberSearchResponse> followerList) { | ||
public static FollowListResponse of( | ||
String targetNickname, | ||
List<MemberSearchResponse> followingList, | ||
List<MemberSearchResponse> followerList) { | ||
return new FollowListResponse(targetNickname, followingList, followerList); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
위 코드는 count를 확인하는 용도라 혹시 프론트와 협의해서 추가한 엔드포인트와 같이 변경 가능하실까요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
윤범님이 주신 코멘트 저도 동감하는데요..!
음 기존에 동작하고 있던게 있기도해서 프론트 공수도 체크해봐야 할 것 같아요ㅜ
스펙도 프론트랑 정해두어서 우선순위에 있는대로 우선 가고 나중에 3차 스프린트 끝나고 리팩토링 하는게 좋을 것 같아용