-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 유저 팔로잉/팔로워 목록 조회 API #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 달았습니당
|
||
// 팔로잉, 팔로워 리스트 응답 | ||
@GetMapping("/{targetId}/list") | ||
@Operation(summary = "팔로잉, 팔로워 유저 리스트를 반환합니다", description = "팔로잉, 팔로워 유저들을 반환합니다.") | ||
public FollowListResponse followList(@PathVariable Long targetId) { | ||
return followService.findFollowList(targetId); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GetMapping("/{targetId}")
@Operation(
summary = "타인의 팔로우 카운트 확인",
description = "타인의 팔로잉/팔로워 카운트와 내가 타인을 팔로우를 하고있는지 확인합니다.")
public FollowFindTargetInfoResponse followFindTarget(@PathVariable Long targetId) {
return followService.findTargetFollowInfo(targetId);
}
위 코드는 count를 확인하는 용도라 혹시 프론트와 협의해서 추가한 엔드포인트와 같이 변경 가능하실까요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
윤범님이 주신 코멘트 저도 동감하는데요..!
음 기존에 동작하고 있던게 있기도해서 프론트 공수도 체크해봐야 할 것 같아요ㅜ
스펙도 프론트랑 정해두어서 우선순위에 있는대로 우선 가고 나중에 3차 스프린트 끝나고 리팩토링 하는게 좋을 것 같아용
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 70 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🌱 관련 이슈
📌 작업 내용 및 특이사항
아래와 같이 API 응답 예정입니다