Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 유저 팔로잉/팔로워 목록 조회 API #274

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

kdomo
Copy link
Member

@kdomo kdomo commented Feb 5, 2024

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • 회원 프로필 페이지에서 팔로잉/팔로워 카운트는 현재 보여주고 있으나, 클릭 시(위 이미지 우측) 리스트를 조회할 수 있어야 합니다.

아래와 같이 API 응답 예정입니다

{
  "success": true,
  "status": 200,
  "data": {
    "targetNickname": "",
    "followingList": [
      {
        "memberId": 2,
        "nickname": "ㅅㄷㄴㅅ",
        "profileImageUrl": "https://kr.object.ncloudstorage.com/10mm-images/local/member_profile/1/image.jpeg",
        "followStatus": "FOLLOWING"
      },
      {
        "memberId": 4,
        "nickname": "4번",
        "profileImageUrl": "https://kr.object.ncloudstorage.com/10mm-images/local/member_profile/1/image.jpeg",
        "followStatus": "FOLLOWING"
      }
    ],
    "followerList": [
      {
        "memberId": 5,
        "nickname": "5",
        "profileImageUrl": "https://kr.object.ncloudstorage.com/10mm-images/local/member_profile/1/image.jpeg",
        "followStatus": "FOLLOWED_BY_ME"
      }
    ]
  },
  "timestamp": "2024-02-05T12:51:27.056682"
}

@kdomo kdomo self-assigned this Feb 5, 2024
@kdomo kdomo added the ✨ feature 새로운 기능 추가 및 수정 label Feb 5, 2024
@kdomo kdomo added this to the 3차 스프린트 milestone Feb 5, 2024
Copy link
Member

@char-yb char-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 달았습니당

Comment on lines +60 to +66

// 팔로잉, 팔로워 리스트 응답
@GetMapping("/{targetId}/list")
@Operation(summary = "팔로잉, 팔로워 유저 리스트를 반환합니다", description = "팔로잉, 팔로워 유저들을 반환합니다.")
public FollowListResponse followList(@PathVariable Long targetId) {
return followService.findFollowList(targetId);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GetMapping("/{targetId}")
    @Operation(
            summary = "타인의 팔로우 카운트 확인",
            description = "타인의 팔로잉/팔로워 카운트와 내가 타인을 팔로우를 하고있는지 확인합니다.")
    public FollowFindTargetInfoResponse followFindTarget(@PathVariable Long targetId) {
        return followService.findTargetFollowInfo(targetId);
    }

위 코드는 count를 확인하는 용도라 혹시 프론트와 협의해서 추가한 엔드포인트와 같이 변경 가능하실까요??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

윤범님이 주신 코멘트 저도 동감하는데요..!
음 기존에 동작하고 있던게 있기도해서 프론트 공수도 체크해봐야 할 것 같아요ㅜ
스펙도 프론트랑 정해두어서 우선순위에 있는대로 우선 가고 나중에 3차 스프린트 끝나고 리팩토링 하는게 좋을 것 같아용

Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

70 New issues
0 Security Hotspots
47.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@char-yb char-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdomo kdomo merged commit 232871f into develop Feb 5, 2024
2 checks passed
@github-actions github-actions bot added the merged 머지된 PR label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature 새로운 기능 추가 및 수정 merged 머지된 PR
Projects
Status: 완료
Development

Successfully merging this pull request may close these issues.

✨ 유저 팔로잉/팔로워 목록
2 participants