Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ usager, pas d'erreur inutile lors d'un double callback FranceConnect #11126

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

colinux
Copy link
Member

@colinux colinux commented Dec 9, 2024

https://demarches-simplifiees.sentry.io/issues/6122564316/
ça évite probablement une erreur côté utilisateur et devrait permettre le flow de signin de continuer

@colinux colinux added the bug label Dec 9, 2024
@colinux colinux requested a review from LeSim December 9, 2024 14:17
@colinux colinux changed the title ETQ usager, pas d'erreur lors d'un double callback FranceConnect ETQ usager, pas d'erreur inutile lors d'un double callback FranceConnect Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (b848179) to head (cb5fa00).
Report is 146 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11126      +/-   ##
==========================================
+ Coverage   84.43%   84.47%   +0.04%     
==========================================
  Files        1182     1187       +5     
  Lines       26112    26256     +144     
  Branches     4920     4946      +26     
==========================================
+ Hits        22047    22180     +133     
- Misses       4065     4076      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinux colinux marked this pull request as draft December 9, 2024 14:30
@colinux
Copy link
Member Author

colinux commented Dec 17, 2024

@LeSim j'étais parti de sentry avant de voir qu'on gérait ce cas dans les tests (et donc les tests passent plus avec cette PR car ils attendent une exception). Mais je sais pas si plutôt que lever une erreur, on ferait pas mieux d'être NOOP (ce que fait cette PR) ? Car l'erreur doit être visible par les usagers vu qu'on fait des redirections derrière. Un avis ?

@colinux colinux force-pushed the fix-useless-exception branch from 66e6abc to cb5fa00 Compare December 17, 2024 14:59
@colinux colinux marked this pull request as ready for review December 17, 2024 16:23
@colinux colinux added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2024
@colinux colinux added this pull request to the merge queue Dec 19, 2024
Merged via the queue into demarches-simplifiees:main with commit 4eb9322 Dec 19, 2024
18 checks passed
@colinux colinux deleted the fix-useless-exception branch December 19, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: En cours
Development

Successfully merging this pull request may close these issues.

2 participants