fix(fc): useless exception when user has already created

demarches-simplifiees · Dec 9, 2024 · 66e6abc · 66e6abc
1 parent b848179
commit 66e6abc
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/app/models/france_connect_information.rb b/app/models/france_connect_information.rb
@@ -15,6 +15,8 @@ def safely_associate_user!(email)
         password: Devise.friendly_token[0, 20],
         confirmed_at: Time.zone.now
       )
+
+      update_attribute('user_id', user.id)
     rescue ActiveRecord::RecordNotUnique
       # ignore this exception because we check before if user is nil.
       # exception can be raised in race conditions, when FranceConnect calls callback 2 times.
@@ -23,7 +25,6 @@ def safely_associate_user!(email)
     end
 
     clean_tokens_and_requested_email
-    update_attribute('user_id', user.id)
     save!
   end