-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: improve the deserialization logic for components that use a Document Store #6466
Conversation
Can we maybe remove the decorator in a later PR? |
I removed the decorator from the Document Stores in deepset-ai/haystack-core-integrations#76 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go, I would probably isolate the module-loading logic in an utility method at some point but let's merge
Related Issues
Proposed Changes:
Improve the deserialization logic for components that use a Document Store.
It will no longer be necessary to first import the Document Store used to deserialize Pipelines without errors.
Remove the
@document_store
decorator and the registry of Document Stores.How did you test it?
CI, adapted the tests.
Notes for the reviewer
After this change, we should remove the decorator from the Document Stores in haystack-core-integrations.
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.