Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Document Store decorator #76

Merged
merged 3 commits into from
Dec 4, 2023
Merged

remove Document Store decorator #76

merged 3 commits into from
Dec 4, 2023

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Dec 4, 2023

Related to deepset-ai/haystack#6466

  • remove decorator
  • change version numbers in order to prepare the releases of the updated Document Stores

@anakin87 anakin87 marked this pull request as ready for review December 4, 2023 12:01
@anakin87 anakin87 requested a review from a team as a code owner December 4, 2023 12:01
@anakin87 anakin87 requested review from ZanSara and silvanocerza and removed request for a team December 4, 2023 12:01
masci
masci previously requested changes Dec 4, 2023
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd bump more aggressively the version

@anakin87 anakin87 requested a review from masci December 4, 2023 12:31
@anakin87 anakin87 dismissed masci’s stale review December 4, 2023 13:59

addressed changes. Approved by Silvano.

@anakin87 anakin87 merged commit 3999dcc into main Dec 4, 2023
14 checks passed
@anakin87 anakin87 deleted the remove-decorator branch December 4, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants